Skip to content

Fix some phan issues and make tests pass in CI #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Fix some phan issues and make tests pass in CI #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ec69da
Fix some phan issues and make tests pass in CI
samwilson Mar 23, 2024
4e5c351
Merge remote-tracking branch 'origin/main' into phan-fixes
samwilson Dec 18, 2024
3a9ceb3
Update
samwilson Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .phan/baseline.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

return [
'file_suppressions' => [
'src/ActivityApi.php' => ['PhanUnextractableAnnotation'],
'src/BlogsApi.php' => ['PhanUnextractableAnnotation'],
'src/CamerasApi.php' => ['PhanUnextractableAnnotation'],
'src/CollectionsApi.php' => ['PhanUnextractableAnnotation'],
'src/CommonsApi.php' => ['PhanUnextractableAnnotation'],
Expand Down
4 changes: 2 additions & 2 deletions src/ActivityApi.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class ActivityApi extends ApiMethodGroup
* omitted, it defaults to 10. The maximum allowed value is 50.
* @param string $page The page of results to return. If this argument is omitted,
* it defaults to 1.
* @return
* @return array
*/
public function userComments($perPage = null, $page = null)
{
Expand All @@ -41,7 +41,7 @@ public function userComments($perPage = null, $page = null)
* omitted, it defaults to 10. The maximum allowed value is 50.
* @param string $page The page of results to return. If this argument is omitted,
* it defaults to 1.
* @return
* @return array
*/
public function userPhotos($timeframe = null, $perPage = null, $page = null)
{
Expand Down
6 changes: 3 additions & 3 deletions src/BlogsApi.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class BlogsApi extends ApiMethodGroup
* @param string $service Optionally only return blogs for a given service id. You
* can get a list of from <a
* href="/services/api/flickr.blogs.getServices.html">flickr.blogs.getServices()</a>.
* @return
* @return array
*/
public function getList($service = null)
{
Expand All @@ -30,7 +30,7 @@ public function getList($service = null)
*
* @link https://www.flickr.com/services/api/flickr.blogs.getServices.html
*
* @return
* @return array
*/
public function getServices()
{
Expand All @@ -50,7 +50,7 @@ public function getServices()
* a blog id you can pass a service id and we'll post to the first blog of that
* service we find.
* @param string $blogId The id of the blog to post to.
* @return
* @return array
*/
public function postPhoto($photoId, $title, $description, $blogPassword = null, $service = null, $blogId = null)
{
Expand Down
3 changes: 0 additions & 3 deletions tests/ApiMethodGroup/PhotosApiTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@ protected function getTestPhotoId(PhpFlickr $flickr)
return $this->testPhotoId;
}

/**
* @group auth
*/
public function testAddTags()
{
$flickr = $this->getFlickr(true);
Expand Down
Loading