Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We have a bug where if you filter by "honors" and "campus", you won't guarantee that there will be one section with the given honors and campus. This will guarantee each class returned has one section matching both filters, and it filters out the rest of the sections as well.
Tickets
https://trello.com/c/v6dY3aCt/416-section-filters-should-only-return-classes-that-have-sections-that-match-both-filters
Contributors
@ananyaspatil @sebwittr
Feature List
Notes (Optional)
The aggregations are still inaccurate (if you turn on the honors filter, and then click the campus filter you'll see that there are a lot of campus options that lead to no results after clicking it). We'll need to make a separate ticket for this!
Reviewers
Primary reviewer: @pranavphadke1 @soulwa
Secondary reviewers:
@ananyaspatil @Anzhuo-W
Original results:
With the new filtering: