-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test serializers #235
base: master
Are you sure you want to change the base?
Test serializers #235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of unit.test.ts
and integration.test.ts
could you please instead put each test type in the appropriate directory and renamed to something more descriptive to their role for the serializers. I understand that the fixtures need to be shared, so those can just live in the tests
dir. That way our integration and unit tests don't get jumbled together
Does this PR succeed #220? If so, can you please clean it up to prepare for the changes here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given what we discussed, we should move forward with the way it is now and refactor all of the tests at a later date
Purpose
Added unit and integration tests for the recently refactored serializers. We previously had no serializer tests, and these tests will ensure that any future changes to the serializers will not produce unintended results.
Contributors
@nickpfeiffer05
Feature List
integration.test.ts
andunit.test.ts
in theserializers
testing folder. Produced sample course data for testing in thefixtures
folderReviewers
Primary reviewer:
Primary:
@ananyaspatil
Secondary reviewers:
Secondary:
@Anzhuo-W @mehallhm @cherman23