Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test serializers #235

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Test serializers #235

wants to merge 13 commits into from

Conversation

nickpfeiffer05
Copy link

@nickpfeiffer05 nickpfeiffer05 commented Oct 27, 2024

Purpose

Added unit and integration tests for the recently refactored serializers. We previously had no serializer tests, and these tests will ensure that any future changes to the serializers will not produce unintended results.

Contributors

@nickpfeiffer05

Feature List

  • Added testing files integration.test.ts and unit.test.ts in the serializers testing folder. Produced sample course data for testing in the fixtures folder
  • Wrote unit tests for the bulkSerialize method of all serializers
  • Wrote integration tests for graphQL -> bulkSerialize method of all serializers. This ensures that all course data retrieved from database data is serialized correctly.

Reviewers

Primary reviewer:

Primary:

@ananyaspatil

Secondary reviewers:

Secondary:

@Anzhuo-W @mehallhm @cherman23

@coveralls
Copy link
Collaborator

coveralls commented Oct 27, 2024

Coverage Status

coverage: 80.391% (+0.2%) from 80.173%
when pulling 33d52df on test-serializers
into 561f7ea on master.

Copy link
Contributor

@mehallhm mehallhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of unit.test.ts and integration.test.ts could you please instead put each test type in the appropriate directory and renamed to something more descriptive to their role for the serializers. I understand that the fixtures need to be shared, so those can just live in the tests dir. That way our integration and unit tests don't get jumbled together

@mehallhm
Copy link
Contributor

Does this PR succeed #220? If so, can you please clean it up to prepare for the changes here.

@mehallhm mehallhm mentioned this pull request Oct 28, 2024
Copy link
Contributor

@mehallhm mehallhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given what we discussed, we should move forward with the way it is now and refactor all of the tests at a later date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants