Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nu path modals/frontend add course modal 668 #699

Merged
merged 8 commits into from
Feb 25, 2024

Conversation

dkd2101
Copy link
Contributor

@dkd2101 dkd2101 commented Feb 1, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Closes #668

Type of change

Please tick the boxes that best match your changes.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

Please describe how you tested this PR (both manually and with tests) Provide instructions so we can reproduce.

  • Go into the website and add a new course. Enter a query and then select NUPaths on the side. View NUpath courses displayed and confirm correctness
  • Ensure that the displayed filtered list shows courses by order of number of filtered paths.
  • Look at the modal and compare to the Figma design document in case I missed things

Checklist:

  • I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code where needed
  • I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I've run the end to end tests
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graduatenu-frontend-v2 ❌ Failed (Inspect) Feb 25, 2024 9:00pm

@@ -55,21 +58,22 @@ export const AddCourseModal: React.FC<AddCourseModalProps> = ({
ScheduleCourse2<null>[]
>([]);
const [isLoadingSelectCourse, setIsLoadingSelectCourse] = useState(false);
const [selectedNUPaths, setSelectedNUPaths] = useState<NUPathEnum[]>([]);

// TODO search with empty query
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment

@BrandonLim8890 BrandonLim8890 merged commit cc101af into main Feb 25, 2024
6 of 7 checks passed
@BrandonLim8890 BrandonLim8890 deleted the NUPathModals/frontend-add-course-modal-668 branch February 25, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Add Course Modal
3 participants