capped years at 5

[23langloisj]

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

It doesn't make sense to have a plan for more than five years. Now the button to add a year will be disabled if there are already 5 years in your plan.

Closes # (762)

Type of change

Please tick the boxes that best match your changes.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• This requires a run of yarn install
• This has migration changes and requires a run of yarn dev:migration:run

How Has This Been Tested?

Please describe how you tested this PR (both manually and with tests) Provide instructions so we can reproduce.

• Test A
• Test B

Checklist:

• [] I have run the production builds in docker for the frontend/backend and ensure things run fine. Check README of repo on how to run if not sure.
• I have performed a self-review of my own code
• I have commented my code where needed
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I've run the end to end tests
• Any dependent changes have been merged and published in downstream modules

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
graduatenu-frontend-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 17, 2024 9:25pm

[denniwang]

GOODOCS

[denniwang]

this is a splendid move right here

[denniwang]

goodocs