Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#216 form instance assign fields and groups #223

Merged
merged 33 commits into from
Dec 4, 2024
Merged

#216 form instance assign fields and groups #223

merged 33 commits into from
Dec 4, 2024

Conversation

DonnyLe
Copy link
Contributor

@DonnyLe DonnyLe commented Dec 2, 2024

Description

Implemented a frontend page for assigners to add text fields to forms for employees to sign. Uses React RND and React PDF

Motivation and Context

Needed a frontend for the assigners to interact with textboxes and PDFs.

Closes [#216 ]

How has this been tested?

Screenshots (if appropriate):

image

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

DonnyLe and others added 23 commits November 9, 2024 16:17
@DonnyLe
Imported starter code and fixed typescript bugs
172ccc5
@DonnyLe
working on bugs
b1aee16
@DonnyLe
Merge branch 'main' into add-text-fields-to-form-template
f0e0585
@DonnyLe
pdf viewer working (functionality broken tho)
b85bea4
@DonnyLe
fixed text boxes being behind pdf
8629961
@DonnyLe
fixed coordinate system
45b5e63
@DonnyLe
completely broken but replaced react-draggable with react-rnd
b603834
@DonnyLe
worked on frontend
b1baa1b
@DonnyLe
broken but fixed some bugs
f09bae1
@DonnyLe
multiple boxes + grouping works
a19dc70
@DonnyLe
Update AssignInput.tsx
effb4e8
@Gayatri-K26
Made some front-end changes to match figma file
9cf7152
@DonnyLe
fixed zooming in and added overflow scroll to page
c946d7e
@DonnyLe
fixed frontend to match figma more
14d365c
@DonnyLe
fixes to make it better accuracy to figma
35fcf80
@DonnyLe
Update AssignInput.tsx
5c920c7
@kaiyangzheng
merge
613c2bf
@kaiyangzheng
Clean up form editor and make draggable text work
bd7bd5e
@kaiyangzheng
Finish form editor with draggable text
a1457cd
@kaiyangzheng
fix imports
226bd43
@kaiyangzheng
test
85dcb66
@DonnyLe
refactored to support multiple pages and complete styling + fixed bugs
c8ea7ad
@DonnyLe
Merge branch 'main' into #216-Form-Instance-Assign-Fields-and-Groups
7806953
@DonnyLe DonnyLe linked an issue Dec 2, 2024 that may be closed by this pull request
[FEATURE] Create form instance "Assign Groups" page #216
Closed
@vercel Vercel
Copy link

vercel bot commented Dec 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mfa-form-automator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 10:48pm

kaiyangzheng
kaiyangzheng requested changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@kaiyangzheng kaiyangzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments.

If possible can you add the component to web/src/pages/create-tempate/inputFields.tsx? You should be able to get the formUrl from useBlob in the useCreateFormTemplate context.

apps/web/src/components/createFormTemplate/createFormTemplateEditor/DraggableSignature.tsx Outdated Show resolved Hide resolved
apps/web/src/components/createFormTemplate/createFormTemplateEditor/DraggableText.tsx Show resolved Hide resolved
apps/web/src/components/createFormTemplate/createFormTemplateEditor/FormEditor.tsx Outdated Show resolved Hide resolved
apps/web/src/components/createFormTemplate/createFormTemplateEditor/FormEditor.tsx Outdated Show resolved Hide resolved
apps/web/src/components/createFormTemplate/createFormTemplateEditor/FormEditor.tsx Outdated Show resolved Hide resolved
apps/web/src/components/createFormTemplate/createFormTemplateEditor/FormEditor.tsx Outdated Show resolved Hide resolved
apps/web/src/components/createFormTemplate/createFormTemplateEditor/DraggableText.tsx Show resolved Hide resolved
apps/web/src/components/createFormTemplate/createFormTemplateEditor/FormEditor.tsx Outdated Show resolved Hide resolved
apps/web/src/components/createFormTemplate/createFormTemplateEditor/FormEditor.tsx Outdated Show resolved Hide resolved
apps/web/src/components/createFormTemplate/createFormTemplateEditor/FormEditor.tsx Outdated Show resolved Hide resolved
@DonnyLe
integrated with create template pages
725db76 
did not integrate with the summary page however.
kaiyangzheng
kaiyangzheng previously approved these changes Dec 4, 2024
View reviewed changes
@kaiyangzheng kaiyangzheng merged commit c73d3b1 into main Dec 4, 2024
7 checks passed
@kaiyangzheng kaiyangzheng deleted the #216-Form-Instance-Assign-Fields-and-Groups branch December 4, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyangzheng kaiyangzheng kaiyangzheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Create form instance "Assign Groups" page
3 participants
@DonnyLe @kaiyangzheng @Gayatri-K26