Updated interrupt based blocking callback to loop based non-blocking one #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a great addition! I've been using the anonymous function idea used here too and the issue is mentioned here too: #127 would it help this to get merged if instead of being implemented in the examples, the anonymous function were added as a default argument to the Lora.onReceive() function? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I noticed from the source code, the onTxDone and onReceive callback is executed in an ISR. According to Arduino and ESP documentation, ISR should run nothing more than simple variable manipulation. Also, delay will not work. I have updated the code to sort out these limitations. Please accept this pull request if you think this could be helpful in time critical application