Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eparish1/op inf #35

Merged
merged 20 commits into from
Jan 14, 2025
Merged

Eparish1/op inf #35

merged 20 commits into from
Jan 14, 2025

Conversation

eparish1
Copy link
Collaborator

@eparish1 eparish1 commented Jan 7, 2025

PR for op inf branch. The code is primarily orthogonal, and the main design concept is an opinf model that contains the ROM operators as well as a SM model that we interface with. I'll try and highlight changes to existing code blocks:

  1. In ics_bcs.jl, you will see the addition of a few "typeof" commands in the blocks for the Schwarz DBCs. These are needed to enable coupling between the FOM and ROM subdomains. If we wanted to avoid these, we'd need to overload the BCs on the model and the coupled domain model.
  2. You will observe the addition of side_set_name to SMOverlapSchwarzBC. This is required so that we know what ROM operator corresponds to what sideset.
  3. In simulation.jl, you'll notice a slight re-org of how the different classes are constructed. This is done so that integrator and solver can be overloaded based on the model.
  4. Subsequently, you will see that HessianMinimizer and Newmark now require a model for construction. They pull the number of dofs from the model class. I haven't done this for all the different solvers and time schemes, but I could.

@eparish1 eparish1 requested review from lxmota and ikalash January 7, 2025 16:39
@eparish1 eparish1 self-assigned this Jan 7, 2025
@eparish1 eparish1 marked this pull request as draft January 7, 2025 18:25
@eparish1
Copy link
Collaborator Author

eparish1 commented Jan 7, 2025

@ikalash @lxmota the CI failed, so I'll have this as a draft until I diagnose.

@ikalash
Copy link
Collaborator

ikalash commented Jan 7, 2025

Thanks for working on this @eparish1 ! I will take a look for sure, but lets have Alejandro make the final call on merging since he may have structural/design suggestions based on his vision for Norma. He will be back from travel on Mon. Jan. 13.

@eparish1 eparish1 marked this pull request as ready for review January 7, 2025 19:13
@eparish1
Copy link
Collaborator Author

eparish1 commented Jan 7, 2025

@ikalash @lxmota the CI failed, so I'll have this as a draft until I diagnose.

CI is fixed, was related to the manifest.toml

@lxmota lxmota merged commit 0c9c214 into main Jan 14, 2025
6 checks passed
@eparish1 eparish1 deleted the eparish1/op-inf branch January 28, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants