Bugfix/multi material with internal variables #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes from a request from a collaborator to be able to do multi-material simulations with history-dependent materials. This overlap of capabilities had been intentionally omitted due to time constraints. The PR does two things:
(ne, neqp, nint)
, wherene
is the number of elements (same as before),neqp
is the number of quadrature points per element (same as before), andnint
is the maximum of the number of internal variables for a material over all materials. This wastes memory, but makes the implementation easier. We can revisit this later if necessary. Probably the entire multi-material design needs to be rethought and unified with the single material implementation. I noted another potential performance concern, which is that the elements in each block are not enforced to be consecutive. This is a bigger concern, since it will likely be a big speed hit. I opened issue Ensure elements in blocks are consecutive #25 to keep track of this.I didn't add unit testing of the multi-material capability, so I opened issue #26 . As I noted above, I think the design needs to be re-thought anyway. I would like to get opinions from Tupek and others on this.