-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove commented-out function definitions and delete files with no executable code #452
base: develop
Are you sure you want to change the base?
Commits on Sep 30, 2024
-
initial attempt at removing out unneeded commented-out function defin…
…itions. Likely over-zealous.
Configuration menu - View commit details
-
Copy full SHA for 10ba164 - Browse repository at this point
Copy the full SHA 10ba164View commit details -
Add guardrails around public model attributes
These changes address unexpected behavior that can occur when manually adding an operation without then manually rebuilding the parameter vector. When this happens it is possible for the Model's internal attributes to fall out of sync with those of it's child objects. Now we check for the need to rebuild the parameter vector every time.
Configuration menu - View commit details
-
Copy full SHA for ccc6464 - Browse repository at this point
Copy the full SHA ccc6464View commit details -
Allow SIGINT set to be skipped via env variable.
This is relevant when attempting to use Dask outside of pyGSTi, where signals cannot be set in the workers. Setting the PYGSTI_NO_CUSTOMLM_SIGINT env variable now skips this behavior.
Configuration menu - View commit details
-
Copy full SHA for 0a1b0ca - Browse repository at this point
Copy the full SHA 0a1b0caView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd7bfe2 - Browse repository at this point
Copy the full SHA dd7bfe2View commit details -
Fix a bug with parameter label management for interposers
A bug in the parameter label handling code was causing parameter labels to explode exponentially in size when _rebuild_paramvec was caused, leading to major memory issues. This now makes it so that the value of _paramlbls is fixed to that of the underlying operations and adds a new version of the parameter_labels property that goes through the interposer (making the interposer labels something generated on demand). Also add a threshold for coefficients printing in the LinearInterposer to avoid obnoxious labels.
Configuration menu - View commit details
-
Copy full SHA for bbbb471 - Browse repository at this point
Copy the full SHA bbbb471View commit details -
Initial implementation of caching for layout creation
The creation of COPA layouts relies on a number of specialized circuit structures which require non-trivial time to construct. In the context of iterative GST estimation with nested circuit lists (i.e. the default) this results in unnecessarily repeat construction of these objects. This is an initial implementation of a caching scheme allowing for more efficient re-use of these circuit structures across iterations.
Configuration menu - View commit details
-
Copy full SHA for 9522fb5 - Browse repository at this point
Copy the full SHA 9522fb5View commit details -
Add caching for spam-free circuit expansion
Cache the expanded SPAM-free circuits to reduce recomputing things unnecessarily.
Configuration menu - View commit details
-
Copy full SHA for 6383cc3 - Browse repository at this point
Copy the full SHA 6383cc3View commit details -
New method for doing bulk intrument/effect expansion
Adds a new method to OpModel that allows for doing instrument expansion and povm expansion in bulk, speeding things up be avoiding recomputation of shared quantities. Also adds a pipeline for re-using completed or split circuits (as produced by the related OpModel methods) for more efficient re-use of done work.
Configuration menu - View commit details
-
Copy full SHA for 093247b - Browse repository at this point
Copy the full SHA 093247bView commit details -
Minor COPA Layout __init__ tweaks
Some minor performance oriented tweaks to the init for COPA layouts.
Configuration menu - View commit details
-
Copy full SHA for 9d57884 - Browse repository at this point
Copy the full SHA 9d57884View commit details -
Refactor some OrderedDicts into regular ones
Refactor some of the ordered dictionaries in matrix layout creation into regular ones.
Configuration menu - View commit details
-
Copy full SHA for aa9519d - Browse repository at this point
Copy the full SHA aa9519dView commit details -
Start the process of adding caching to MDC store creation
Start adding infrastructure for caching things used in MDC store creation and for plumbing in stuff from layout creation.
Configuration menu - View commit details
-
Copy full SHA for 957facd - Browse repository at this point
Copy the full SHA 957facdView commit details -
Tweak omitted freqs and counts + DataSet and slicetools
Performance optimization for the method for adding omitted frequencies to incorporate caching of the number of outcomes per circuit (which is somewhat expensive since it goes through the instrument/povm expansion code). Additionally refactor some other parts of this code for improved efficiency. Also makes a few minor tweaks to the method for adding counts to speed that up as well. Can probably make this a bit faster still by merging the two calls to reduce redundancy, but that is a future us problem. Additionally make a few microoptimizations to the dataset code for grabbing counts, and to slicetools adding a function for directly giving a numpy array for a slice (instead of needing to cast from a list). Miscellaneous cleanup of old commented out code that doesn't appear needed any longer.
Configuration menu - View commit details
-
Copy full SHA for 9df2a61 - Browse repository at this point
Copy the full SHA 9df2a61View commit details -
Fix a bug I introduced in dataset indexing into something that could be None.
Configuration menu - View commit details
-
Copy full SHA for 8d5cfc7 - Browse repository at this point
Copy the full SHA 8d5cfc7View commit details -
Another minor bugfix caught by testing
Another minor bug caught by testing.
Configuration menu - View commit details
-
Copy full SHA for cd653b3 - Browse repository at this point
Copy the full SHA cd653b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd1e8d1 - Browse repository at this point
Copy the full SHA fd1e8d1View commit details -
Faster implementation of __getitem__
Improve the performance of __getitem__ when indexing into static circuits by making use of the _copy_init code path.
Configuration menu - View commit details
-
Copy full SHA for 1ee6112 - Browse repository at this point
Copy the full SHA 1ee6112View commit details -
Implement caching for map layout creation
Implement caching of circuit structures tailored to the map forward simulator's requirements.
Configuration menu - View commit details
-
Copy full SHA for 1c83f9b - Browse repository at this point
Copy the full SHA 1c83f9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a38689 - Browse repository at this point
Copy the full SHA 7a38689View commit details -
Finish refactoring expand_instruments_and_separate_povm
This finishes the process of refactoring expand_instruments_and_separate_povm from a circuit method to a method of OpModel.
Configuration menu - View commit details
-
Copy full SHA for 070c2f4 - Browse repository at this point
Copy the full SHA 070c2f4View commit details -
Refactor expand_instruments_and_separate_povm
Refactor expand_instruments_and_separate_povm to use the multi-circuit version under the hood to reduce code duplication.
Configuration menu - View commit details
-
Copy full SHA for 8f80e31 - Browse repository at this point
Copy the full SHA 8f80e31View commit details -
Refactor cache creation functions
Refactor cache creation functions into static methods of the corresponding forward simulator class. Also add an empty base version of this method, and clean up a few miscellaneous things caught by review.
Configuration menu - View commit details
-
Copy full SHA for 007c449 - Browse repository at this point
Copy the full SHA 007c449View commit details -
Add in support for data set key aliasing in COPA layout cache creation.
Configuration menu - View commit details
-
Copy full SHA for bc6d6ca - Browse repository at this point
Copy the full SHA bc6d6caView commit details -
Rework some of the if statement branching in the layout creation to instead use fallback behavior of get more.
Configuration menu - View commit details
-
Copy full SHA for a79f286 - Browse repository at this point
Copy the full SHA a79f286View commit details -
I accidentally put down the wrong directory for temp testing files in the RB testing code.
Configuration menu - View commit details
-
Copy full SHA for c6ed8ee - Browse repository at this point
Copy the full SHA c6ed8eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ec8c87 - Browse repository at this point
Copy the full SHA 9ec8c87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 599faa0 - Browse repository at this point
Copy the full SHA 599faa0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d40eb7 - Browse repository at this point
Copy the full SHA 4d40eb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb9a278 - Browse repository at this point
Copy the full SHA bb9a278View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf7dcd1 - Browse repository at this point
Copy the full SHA cf7dcd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7b99e9 - Browse repository at this point
Copy the full SHA e7b99e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0b6d7d - Browse repository at this point
Copy the full SHA b0b6d7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec12bdb - Browse repository at this point
Copy the full SHA ec12bdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for a156511 - Browse repository at this point
Copy the full SHA a156511View commit details -
Configuration menu - View commit details
-
Copy full SHA for 362788f - Browse repository at this point
Copy the full SHA 362788fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a67f17f - Browse repository at this point
Copy the full SHA a67f17fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e79b2af - Browse repository at this point
Copy the full SHA e79b2afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cdfe87 - Browse repository at this point
Copy the full SHA 2cdfe87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 024d553 - Browse repository at this point
Copy the full SHA 024d553View commit details
Commits on Oct 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5aa5cb7 - Browse repository at this point
Copy the full SHA 5aa5cb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 344670d - Browse repository at this point
Copy the full SHA 344670dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 00982b2 - Browse repository at this point
Copy the full SHA 00982b2View commit details