Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commented-out function definitions and delete files with no executable code #452

Open
wants to merge 41 commits into
base: develop
Choose a base branch
from

Commits on Sep 30, 2024

  1. initial attempt at removing out unneeded commented-out function defin…

    …itions. Likely over-zealous.
    rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    10ba164 View commit details
    Browse the repository at this point in the history
  2. Add guardrails around public model attributes

    These changes address unexpected behavior that can occur when manually adding an operation without then manually rebuilding the parameter vector. When this happens it is possible for the Model's internal attributes to fall out of sync with those of it's child objects. Now we check for the need to rebuild the parameter vector every time.
    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ccc6464 View commit details
    Browse the repository at this point in the history
  3. Allow SIGINT set to be skipped via env variable.

    This is relevant when attempting to use Dask outside of pyGSTi,
    where signals cannot be set in the workers.
    Setting the PYGSTI_NO_CUSTOMLM_SIGINT env variable
    now skips this behavior.
    sserita authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    0a1b0ca View commit details
    Browse the repository at this point in the history
  4. Logic bugfix

    sserita authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    dd7bfe2 View commit details
    Browse the repository at this point in the history
  5. Fix a bug with parameter label management for interposers

    A bug in the parameter label handling code was causing parameter labels to explode exponentially in size when _rebuild_paramvec was caused, leading to major memory issues. This now makes it so that the value of _paramlbls is fixed to that of the underlying operations and adds a new version of the parameter_labels property that goes through the interposer (making the interposer labels something generated on demand). Also add a threshold for coefficients printing in the LinearInterposer to avoid obnoxious labels.
    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    bbbb471 View commit details
    Browse the repository at this point in the history
  6. Initial implementation of caching for layout creation

    The creation of COPA layouts relies on a number of specialized circuit structures which require non-trivial time to construct. In the context of iterative GST estimation with nested circuit lists (i.e. the default) this results in unnecessarily repeat construction of these objects. This is an initial implementation of a caching scheme allowing for more efficient re-use of these circuit structures across iterations.
    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9522fb5 View commit details
    Browse the repository at this point in the history
  7. Add caching for spam-free circuit expansion

    Cache the expanded SPAM-free circuits to reduce recomputing things unnecessarily.
    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    6383cc3 View commit details
    Browse the repository at this point in the history
  8. New method for doing bulk intrument/effect expansion

    Adds a new method to OpModel that allows for doing instrument expansion and povm expansion in bulk, speeding things up be avoiding recomputation of shared quantities. Also adds a pipeline for re-using completed or split circuits (as produced by the related OpModel methods) for more efficient re-use of done work.
    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    093247b View commit details
    Browse the repository at this point in the history
  9. Minor COPA Layout __init__ tweaks

    Some minor performance oriented tweaks to the init for COPA layouts.
    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9d57884 View commit details
    Browse the repository at this point in the history
  10. Refactor some OrderedDicts into regular ones

    Refactor some of the ordered dictionaries in matrix layout creation into regular ones.
    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    aa9519d View commit details
    Browse the repository at this point in the history
  11. Start the process of adding caching to MDC store creation

    Start adding infrastructure for caching things used in MDC store creation and for plumbing in stuff from layout creation.
    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    957facd View commit details
    Browse the repository at this point in the history
  12. Tweak omitted freqs and counts + DataSet and slicetools

    Performance optimization for the method for adding omitted frequencies to incorporate caching of the number of outcomes per circuit (which is somewhat expensive since it goes through the instrument/povm expansion code). Additionally refactor some other parts of this code for improved efficiency. Also makes a few minor tweaks to the method for adding counts to speed that up as well. Can probably make this a bit faster still by merging the two calls to reduce redundancy, but that is a future us problem. Additionally make a few microoptimizations to the dataset code for grabbing counts, and to slicetools adding a function for directly giving a numpy array for a slice (instead of needing to cast from a list).
    
    Miscellaneous cleanup of old commented out code that doesn't appear needed any longer.
    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9df2a61 View commit details
    Browse the repository at this point in the history
  13. Fix dataset bug

    Fix a bug I introduced in dataset indexing into something that could be None.
    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    8d5cfc7 View commit details
    Browse the repository at this point in the history
  14. Another minor bugfix caught by testing

    Another minor bug caught by testing.
    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    cd653b3 View commit details
    Browse the repository at this point in the history
  15. Another minor bugfix caught by testing

    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    fd1e8d1 View commit details
    Browse the repository at this point in the history
  16. Faster implementation of __getitem__

    Improve the performance of __getitem__ when indexing into static circuits by making use of the _copy_init code path.
    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1ee6112 View commit details
    Browse the repository at this point in the history
  17. Implement caching for map layout creation

    Implement caching of circuit structures tailored to the map forward simulator's requirements.
    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1c83f9b View commit details
    Browse the repository at this point in the history
  18. Fix bugs in new extract_labels implementation

    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7a38689 View commit details
    Browse the repository at this point in the history
  19. Finish refactoring expand_instruments_and_separate_povm

    This finishes the process of refactoring expand_instruments_and_separate_povm from a circuit method to a method of OpModel.
    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    070c2f4 View commit details
    Browse the repository at this point in the history
  20. Refactor expand_instruments_and_separate_povm

    Refactor expand_instruments_and_separate_povm to use the multi-circuit version under the hood to reduce code duplication.
    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    8f80e31 View commit details
    Browse the repository at this point in the history
  21. Refactor cache creation functions

    Refactor cache creation functions into static methods of the corresponding forward simulator class. Also add an empty base version of this method, and clean up a few miscellaneous things caught by review.
    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    007c449 View commit details
    Browse the repository at this point in the history
  22. Add in DataSet key aliasing

    Add in support for data set key aliasing in COPA layout cache creation.
    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    bc6d6ca View commit details
    Browse the repository at this point in the history
  23. Minor refactors and updates

    Rework some of the if statement branching in the layout creation to instead use fallback behavior of get more.
    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a79f286 View commit details
    Browse the repository at this point in the history
  24. Unrelated RB testing fix

    I accidentally put down the wrong directory for temp testing files in the RB testing code.
    Corey Ostrove authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c6ed8ee View commit details
    Browse the repository at this point in the history
  25. Make test_rb paths absolute.

    sserita authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9ec8c87 View commit details
    Browse the repository at this point in the history
  26. Fix beta tests.

    sserita authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    599faa0 View commit details
    Browse the repository at this point in the history
  27. Merge resolution with #488.

    sserita authored and rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    4d40eb7 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    bb9a278 View commit details
    Browse the repository at this point in the history
  29. check in

    rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    cf7dcd1 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    e7b99e9 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    b0b6d7d View commit details
    Browse the repository at this point in the history
  32. tests pass

    rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ec12bdb View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    a156511 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    362788f View commit details
    Browse the repository at this point in the history
  35. interpygate helpers

    rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a67f17f View commit details
    Browse the repository at this point in the history
  36. remove safe_dot

    rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e79b2af View commit details
    Browse the repository at this point in the history
  37. rebase step 1

    rileyjmurray committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2cdfe87 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    024d553 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Configuration menu
    Copy the full SHA
    5aa5cb7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    344670d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    00982b2 View commit details
    Browse the repository at this point in the history