Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes to the Basis class to help with my leakage PR (#410).
Specifics, at time of writing:
About EmbeddedBasis ...
It turns out that the EmbeddedBasis class isn't used anywhere in pyGSTi. (There are a few places that import it, but they still never use it.) I discovered this when I got an error trying to access
eb.elements
for an EmbeddedBasiseb
. That trigged evaluation of EmbeddedBasis._lazy_build_elements, which tried to call an undefined function. See here for a repo-wide search for that function.I'd like to use this PR as an opportunity to either (a) make EmbeddedBasis work, possibly with new semantics, or (b) remove EmbeddedBasis altogether.