Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qarray Race Condition Fixes #242

Conversation

insertinterestingnamehere
Copy link
Collaborator

WIP. Will eventually fix #240.

@insertinterestingnamehere insertinterestingnamehere marked this pull request as draft February 13, 2024 23:55
@insertinterestingnamehere insertinterestingnamehere changed the base branch from main to release-1.20-pre February 13, 2024 23:55
@insertinterestingnamehere insertinterestingnamehere marked this pull request as ready for review March 21, 2024 16:36
@insertinterestingnamehere
Copy link
Collaborator Author

Actually the remaining errors were from other sections of code. Reducing the problem size a bit like I did here is still a good idea tho.

Copy link
Collaborator

@janciesko janciesko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (The commit message explains what is going on here)

@insertinterestingnamehere insertinterestingnamehere merged commit 6fa7967 into sandialabs:release-1.20-pre Mar 26, 2024
174 of 297 checks passed
@insertinterestingnamehere
Copy link
Collaborator Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race Conditions and Deadlock in qarray Test With Thread Sanitizer
2 participants