Atomics For Spinning Waiter in qthread_readstate Test #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pefully this will fix the intermittent hang in CI in this test.
insertinterestingnamehere
force-pushed
the
hang
branch
from
74e4832 to
f8fcfbd
Compare
insertinterestingnamehere
merged commit bf6c4d0
into
sandialabs:release-1.22-pre
349 of 359 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hoping (optimistically) that this fixes #342. It'll probably take a long while to confirm though since the hang is so intermittent. This PR certainly fixes a valid bug either way though since the old version of this test was a data race as-written.