RTDS provider fixes and improvements #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The license file was already included in the source tree. However, it wasn't listed in NOTICE.
- Remove PMU sequence numbers. They ended up being wildly inaccurate thanks to threading. - Apply a field type mapping when creating Elasticsearch indices - Handle Elastic bulk ingest error messages - Add 'elastic-index-basename' option to configure the Elasticsearch index name. - Fix PMU connection rebuilding. If RSCAD case is stopped, the provider no longer needs to be restarted and will properly restart the PMU connections. This fixes a long-standing issue that's been around since HARMONIE. - Improve PMU handling. RTDS provider is now able to be started AFTER the RSCAD case is started. - Change gtnet-skt to continually send data over UDP - Add 'gtnet-skt-tcp-retry-delay' config option - Add 'gtnet-skt-udp-write-rate' config option - Move Elasticsearch processing and pushing into a thread. This prevents it from blocking the core functionality of sending data to SCEPTRE. - Improve how boolean config options are handled - Move RTDS data processing into a thread
tox hasn't been used by pybennu for a very, very long time
Git hashes can't be used for the Version field in package metadata
It isn't used anywhere. It's a pyinstaller spec but pyinstaller hasn't been used in a long time.
- Remove unused variables and stages - Fix indentation - Consolidate and update help messages - Remove requirement for root from several commands
- Add 'rtds-pmu-protocols' to config.ini - Add ability to use UDP for PMUs in the RTDS - Totally untested right now, will be tested soon
- GTNET-SKT: Don't log every GTNET-SKT tag update - GTNET-SKT: Log all GTNET-SKT values, only when debugging - GTNET-SKT: calculate all the typecasts, THEN update the state all at once (instead of taking the lock 20 times and incrementally updating the state...) - Move a lot of logging to if statements so we avoid function call - asynchronous logging so log calls don't block threads (especially for file writes)
GhostofGoes
changed the title
mgaliar
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the RTDS provider.
rtds-pmu-protocols(for now, onlytcpdoes anything)agent.version.datetime.datetimeobjects