Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEC-104 server and client updates #22

Merged

Conversation

zachbthomas
Copy link
Contributor

Updates to IEC-104 server and client to support double point binary values. Bennu datastore still uses booleans for binary points, so we have to convert back and forth to make this work

…alues. Bennu datastore still uses booleans for binary points, so we have to convert back and forth to make this work
@zachbthomas zachbthomas marked this pull request as draft April 8, 2024 18:40
@zachbthomas zachbthomas marked this pull request as ready for review May 8, 2024 22:00
Copy link
Collaborator

@GhostofGoes GhostofGoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. I have some nitpicks and minor issues that should be relatively straightforward to address.

Copy link
Collaborator

@mgaliar mgaliar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GhostofGoes GhostofGoes merged commit 9b8cbca into sandialabs:main May 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants