Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add publish rate parameter #25

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Add publish rate parameter #25

merged 3 commits into from
Aug 14, 2024

Conversation

areyna1
Copy link
Contributor

@areyna1 areyna1 commented Jul 26, 2024

added parameter for changing publish rate

@GhostofGoes GhostofGoes self-assigned this Jul 30, 2024
@GhostofGoes GhostofGoes self-requested a review August 7, 2024 18:00
GhostofGoes
GhostofGoes requested changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@GhostofGoes GhostofGoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename your PR to be the feature you're adding.

src/bennu/executables/bennu-simulink-provider/main.cpp Show resolved Hide resolved
src/bennu/executables/bennu-simulink-provider/main.cpp Outdated Show resolved Hide resolved
src/bennu/executables/bennu-simulink-provider/main.cpp Show resolved Hide resolved
src/bennu/executables/bennu-simulink-provider/main.cpp Outdated Show resolved Hide resolved
src/bennu/executables/bennu-simulink-provider/main.cpp Outdated Show resolved Hide resolved
@areyna1 areyna1 changed the title Update main.cpp Add publish rate parameter Aug 7, 2024
GhostofGoes
GhostofGoes approved these changes Aug 10, 2024
View reviewed changes
Copy link
Collaborator

@GhostofGoes GhostofGoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One thought for future, make publishRate_setting type of auto, and call durationToDuration in the constructor. Calling it every time the thread sleeps is unnecessary since the value never changes.

@GhostofGoes
Copy link
Collaborator

@mgaliar when you have time, can you give this a cursury glance and blessing before I merge it?

@mgaliar
Copy link
Collaborator

mgaliar commented Aug 13, 2024

Looks good!

@GhostofGoes
Copy link
Collaborator

One note: this changes the default behavior from polling every second (if I read the code correctly) to polling every 100ms. Shouldn't impact anything negatively.

@GhostofGoes GhostofGoes merged commit 9380575 into sandialabs:main Aug 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgaliar mgaliar mgaliar approved these changes

@GhostofGoes GhostofGoes GhostofGoes approved these changes

Assignees

@GhostofGoes GhostofGoes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@areyna1 @GhostofGoes @mgaliar