feat(scorch): output additional logs to console

sandialabs · Jul 25, 2024 · 09d1f08 · 09d1f08
1 parent 60a13b7
commit 09d1f08
Showing 1 changed file with 36 additions and 0 deletions.
diff --git a/src/go/api/scorch/app.go b/src/go/api/scorch/app.go
@@ -385,6 +385,8 @@ func executor(ctx context.Context, components scorchmd.ComponentSpecMap, exe *sc
 		loopPrefix = fmt.Sprintf("[RUN: %d - LOOP: %d - COUNT: %d]", options.Run, options.Loop, options.Count)
 	)
 
+	logger := plog.LoggerFromContext(ctx)
+
 	if options.Loop == 0 {
 		scorch.DeletePipeline(exp, options.Run, -1, true)
 	}
@@ -396,6 +398,8 @@ func executor(ctx context.Context, components scorchmd.ComponentSpecMap, exe *sc
 		Count: options.Count,
 	}
 
+	logger.Info("starting scorch", "run", loopPrefix)
+
 	configure := func() error {
 		update.Stage = string(ACTIONCONFIG)
 
@@ -407,6 +411,8 @@ func executor(ctx context.Context, components scorchmd.ComponentSpecMap, exe *sc
 			return nil
 		}
 
+		logger.Info("running scorch configure stage")
+
 		for _, name := range exe.Configure {
 			typ := components[name].Type
 
@@ -429,18 +435,24 @@ func executor(ctx context.Context, components scorchmd.ComponentSpecMap, exe *sc
 			scorch.UpdateComponent(update)
 			scorch.UpdatePipeline(update)
 
+			logger.Debug("running scorch configure stage component", "component", name)
+
 			if err := ExecuteComponent(ctx, options...); err != nil {
 				update.Status = "failure"
 				scorch.UpdateComponent(update)
 				scorch.UpdatePipeline(update)
 
+				logger.Error("[✗] failed scorch configure stage component", "component", name, "err", err)
+
 				return fmt.Errorf("%s configuring component %s for experiment %s: %w", loopPrefix, name, exp, err)
 			}
 
 			if !components[name].Background {
 				update.Status = "success"
 				scorch.UpdateComponent(update)
 				scorch.UpdatePipeline(update)
+
+				logger.Debug("[✓] completed scorch configure stage component", "component", name)
 			}
 		}
 
@@ -458,6 +470,8 @@ func executor(ctx context.Context, components scorchmd.ComponentSpecMap, exe *sc
 			return nil
 		}
 
+		logger.Info("running scorch start stage")
+
 		for _, name := range exe.Start {
 			typ := components[name].Type
 
@@ -480,18 +494,24 @@ func executor(ctx context.Context, components scorchmd.ComponentSpecMap, exe *sc
 			scorch.UpdateComponent(update)
 			scorch.UpdatePipeline(update)
 
+			logger.Debug("running scorch start stage component", "component", name)
+
 			if err := ExecuteComponent(ctx, options...); err != nil {
 				update.Status = "failure"
 				scorch.UpdateComponent(update)
 				scorch.UpdatePipeline(update)
 
+				logger.Error("[✗] failed scorch start stage component", "component", name, "err", err)
+
 				return fmt.Errorf("%s starting component %s for experiment %s: %w", loopPrefix, name, exp, err)
 			}
 
 			if !components[name].Background {
 				update.Status = "success"
 				scorch.UpdateComponent(update)
 				scorch.UpdatePipeline(update)
+
+				logger.Debug("[✓] completed scorch start stage component", "component", name)
 			}
 		}
 
@@ -511,6 +531,8 @@ func executor(ctx context.Context, components scorchmd.ComponentSpecMap, exe *sc
 
 		var errors error
 
+		logger.Info("running scorch stop stage")
+
 		for _, name := range exe.Stop {
 			typ := components[name].Type
 
@@ -526,16 +548,22 @@ func executor(ctx context.Context, components scorchmd.ComponentSpecMap, exe *sc
 			scorch.UpdateComponent(update)
 			scorch.UpdatePipeline(update)
 
+			logger.Debug("running stop stage component", "component", name)
+
 			if err := ExecuteComponent(ctx, options...); err != nil {
 				update.Status = "failure"
 				scorch.UpdateComponent(update)
 				scorch.UpdatePipeline(update)
 
+				logger.Error("[✗] failed scorch stop stage component", "component", name, "err", err)
+
 				errors = multierror.Append(errors, fmt.Errorf("%s stopping component %s for experiment %s: %w", loopPrefix, name, exp, err))
 			} else {
 				update.Status = "success"
 				scorch.UpdateComponent(update)
 				scorch.UpdatePipeline(update)
+
+				logger.Debug("[✓] completed scorch stop stage component", "component", name)
 			}
 		}
 
@@ -555,6 +583,8 @@ func executor(ctx context.Context, components scorchmd.ComponentSpecMap, exe *sc
 
 		var errors error
 
+		logger.Info("running scorch cleanup stage")
+
 		for _, name := range exe.Cleanup {
 			typ := components[name].Type
 
@@ -570,17 +600,23 @@ func executor(ctx context.Context, components scorchmd.ComponentSpecMap, exe *sc
 			scorch.UpdateComponent(update)
 			scorch.UpdatePipeline(update)
 
+			logger.Debug("running cleanup stage component", "component", name)
+
 			err := ExecuteComponent(ctx, options...)
 			if err != nil {
 				update.Status = "failure"
 				scorch.UpdateComponent(update)
 				scorch.UpdatePipeline(update)
 
+				logger.Error("[✗] failed scorch cleanup stage component", "component", name, "err", err)
+
 				errors = multierror.Append(errors, fmt.Errorf("%s cleaning up component %s for experiment %s: %w", loopPrefix, name, exp, err))
 			} else {
 				update.Status = "success"
 				scorch.UpdateComponent(update)
 				scorch.UpdatePipeline(update)
+
+				logger.Debug("[✓] completed scorch cleanup stage component", "component", name)
 			}
 		}