User Annotation Improvements #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will allow opening tag dialog once created
rework backend to hold tags in map (need to test with mm) add tags column to stopped experiment
…odal since persistent, makes more sense to refer to it as labels instead of tags
remove context menu from soh add buttons in soh for notes/labels and customizing color include vm tags in soh payload switch to using mixins for global functions
update method for updating vm to allow setting or adding tags
fix exception when opening soh with non-booted node remove debug print statements
|
Thanks @jacdavi, I'll take a look at this ASAP. Looks cool! |
Sounds good. There's one more PR coming soon. No rush on any of them since we have everything in an internal fork. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few features in the UI for making notes and customizing the way a VM appears in the SOH graph. The intent is to make it easier for users to track/manage the status of VMs within an experiment (e.g., a user may mark a node red and add a note "reached by red team")
Adds a new modal for viewing/editing the labels of a VM
Changes SOH details modal to show notes at the top