Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor implements #51

Merged
merged 3 commits into from
Apr 15, 2021
Merged

Conversation

amoodie
Copy link
Contributor

@amoodie amoodie commented Apr 15, 2021

A few minor implementations.

  • add ability to pass kwargs to colorbar instantiation in plot._append_colorbar use. This is helpful for specifying e.g., tick label formatter for plots. Adds test.
  • implement the from_array pathway for ChannelMask. Update tests.

progress on #47

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #51 (baa9d0c) into develop (8a56acb) will decrease coverage by 0.06%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #51      +/-   ##
===========================================
- Coverage    87.51%   87.45%   -0.07%     
===========================================
  Files            9        9              
  Lines         2403     2423      +20     
===========================================
+ Hits          2103     2119      +16     
- Misses         300      304       +4     
Impacted Files Coverage Δ
deltametrics/plot.py 89.07% <0.00%> (-0.65%) ⬇️
deltametrics/mask.py 87.43% <100.00%> (+0.10%) ⬆️
deltametrics/io.py 87.77% <0.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a56acb...baa9d0c. Read the comment docs.

@amoodie amoodie merged commit 5d034d5 into sandpiper-toolchain:develop Apr 15, 2021
@amoodie amoodie deleted the minor_implements branch March 20, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant