Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict the keybinds to todos #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

rbenson
Copy link

@rbenson rbenson commented Mar 12, 2017

issue #12

@rbenson
Copy link
Author

rbenson commented Jun 27, 2017

Hotkeys now do not work regardless if the editorLangID is set or not in vsc v 1.13.1.

@sveggiani
Copy link

sveggiani commented Oct 12, 2017

@rbenson Ufff, I've come here after making a PR and see your PR. Btw there is a double quote missing in your code.

Do you have any hope that this could be merged someday?

@@ -80,17 +80,17 @@
"command": "task.new",
"key": "Ctrl+Enter",
"mac": "Cmd+Enter",
"when": "editorTextFocus"
"when": "editorTextFocus && editorLangId == todo

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing quotes here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I fixed this, but thanks

@senpl
Copy link

senpl commented Mar 28, 2019

any progress on this ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants