Fix issue with wrong Action[Ctx, _] conversion being summoned #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchyb
force-pushed
the
fix-issue-906
branch
3 times, most recently
from
a5215d6 to
d6c967c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual change that fixes the issue is very simple, instead of summoning
[fieldType => Action[Ctx, fieldType]]we summon[fieldType => Action[Ctx, _]], so that we can also summonReduceAcrion.futureActionandtryAction(previously we mistakenly limited ourselves todefaultAction).I also allowed myself to simplify the code a bit, wrapping all of the faux-implicit conversions into a separate method, for readability.
Based on the minimization and research done in #1168 (I moved the test into the
DeriveObjectTypeMacroSuite)Fixes #906