Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #2329

Merged
merged 5 commits into from
Dec 6, 2021
Merged

Fix typos #2329

merged 5 commits into from
Dec 6, 2021

Conversation

kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Dec 2, 2021

No description provided.

@kianmeng kianmeng requested review from a team as code owners December 2, 2021 21:24
ChihweiLHBird
ChihweiLHBird previously approved these changes Dec 2, 2021
Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪨 🌟

Thanks for the PR

@ahopkins ahopkins self-requested a review December 2, 2021 22:29
ahopkins
ahopkins previously approved these changes Dec 2, 2021
@ahopkins ahopkins dismissed stale reviews from ChihweiLHBird and themself via ea919fb December 6, 2021 06:55
@ahopkins
Copy link
Member

ahopkins commented Dec 6, 2021

Looks like the linters were breaking because of a downstream dependency of m2r2 (for docs builds). Downgrading mistune to 0.8.4 seems to fix the problem.

miyakogi/m2r#66

@ahopkins
Copy link
Member

ahopkins commented Dec 6, 2021

Also, I noticed yesterday there was a typo (and incorrect annotation) for the Blueprints(..., host) param. Seems appropriate enough to just clean it up in this PR.

@ahopkins ahopkins merged commit ab35121 into sanic-org:main Dec 6, 2021
ChihweiLHBird pushed a commit to ChihweiLHBird/sanic that referenced this pull request Jun 1, 2022
* Fix typos

* Downgrade mistune version

* Fix blueprint host param

Co-authored-by: Adam Hopkins <[email protected]>
Co-authored-by: Adam Hopkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants