When shutdown type is 'remove' wait for shard drain #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MOVE_WAIT_SECONDS Let TERMINATE_GRACE_PERIOD_SECONDS be an overriable variable. Could potentially be exposed by downward api. make logic simpler and more explicit
nicholasklem
force-pushed
the
nk/wait-for-shard-draining
branch
from
8bff3ad to
2953f08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When shutdown type is 'remove' wait for shard drain up to PRE_STOP_REMOVE_WAIT_SECONDS
Let TERMINATE_GRACE_PERIOD_SECONDS be an overridable variable. Could potentially be exposed by downward api.