feat: allow nested languageField on documents #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
Cool feature! Could you add an update to the Language Field section of the readme so people are aware of this possibility? |
|
Read me updated! :) |
luigifgp
force-pushed
the
nested-object-with-language-field
branch
from
e1e0750
to
8328201
Compare
…into nested-object-with-language-field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently objects such as
options.languageorpageOptions.languageare unabled to use changing the default field forlanguageField.On this PR we are using just-safe-get library, to Get the value at property level. This way we solve fields like:
"abc[0].language""a.abc.language""cde.abc.b.language"feel free to share your opinion about it.