feat: add support for exporting documents with "inconsistent" cursor #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgulseth
commented
Jun 26, 2024
sgulseth
force-pushed
the
feat/add-cursor-support
branch
from
4871b9d to
af0e2b7
Compare
atombender
reviewed
Jul 2, 2024
| return | ||
| } | ||
| } catch (err) { | ||
| // Ignore JSON parse errors |
There was a problem hiding this comment.
Is that wise? Smells like the sort of thing that can cause hard-to-figure-out Node.js problems. Better to be strict in such situations; the stream should not have parse errors.
There was a problem hiding this comment.
I can move the catch into JSON parse only, it's only if it's sending something that isn't json, then the error should be handled by a later consumer. Added a comment
sgulseth
force-pushed
the
feat/add-cursor-support
branch
from
af0e2b7 to
646984e
Compare
sgulseth
force-pushed
the
feat/add-cursor-support
branch
from
646984e to
5679759
Compare
atombender
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit awkward implementation, but we need to handle multiple streams when a cursor is sent by the server. This is also a need code path, so wont affect exports without the flag