Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cursor export on ndjson inside a chunk #15

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Conversation

sgulseth
Copy link
Member

@sgulseth sgulseth commented Jul 22, 2024

A chunk can contain multiple json documents, so we need to split it by newline before parsing it as json

@sgulseth sgulseth requested a review from a team July 22, 2024 09:01
j33ty
j33ty previously approved these changes Jul 22, 2024
Copy link
Contributor

@j33ty j33ty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

src/getDocumentCursorStream.js Outdated Show resolved Hide resolved
src/getDocumentCursorStream.js Outdated Show resolved Hide resolved
j33ty
j33ty previously approved these changes Jul 22, 2024
@sgulseth sgulseth force-pushed the feat/debug-logs-to-stream branch from 0e912ac to 8e2a599 Compare July 22, 2024 12:11
@sgulseth sgulseth changed the title feat: add more debug logs to cursor stream Fix cursor export on ndjson inside a chunk Jul 22, 2024
@sgulseth sgulseth requested a review from j33ty July 22, 2024 12:19
@sgulseth sgulseth merged commit b17e562 into main Jul 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants