Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stringifying of large asset maps by streaming the JSON to file #18

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

atombender
Copy link
Member

No description provided.

@atombender atombender requested a review from a team December 19, 2024 11:49
Copy link

socket-security bot commented Dec 19, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 203 kB faleij

View full report↗︎

@atombender
Copy link
Member Author

Hmm, tests suddenly failed. Looking into it.

@atombender atombender force-pushed the cldx-2937/large-asset-json-stringify branch from 0eb9deb to 75154b8 Compare December 19, 2024 11:51
@atombender
Copy link
Member Author

Typo. Fixed!

Copy link

@danielgroves danielgroves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atombender atombender merged commit f8e24c9 into main Dec 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants