Ignore 404 errors when downloading assets #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rneatherway
reviewed
Dec 19, 2024
src/AssetHandler.js
Outdated
| @@ -112,6 +112,12 @@ class AssetHandler { | |||
| try { | |||
| return await this.downloadAsset(assetDoc, dstPath) | |||
| } catch (err) { | |||
| // Ignore missing assets | |||
| if (err.statusCode === 404) { | |||
There was a problem hiding this comment.
I suggest that we also not fail on 401/403. Similarly, the dataset is somehow odd/a bit broken, but we can still export as much as is accessible to the user.
rneatherway
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently causes the export to fail. I have not looked into why assets would be gone in this case, but that seems like a separate issue that is probably caused by asset documents getting out of async with the files, rather than stuff genuinely going missing. Either way, it should not prevent an export from completing.
Note that we don't have a great way to warn the user, as far as I can see. The importer has a way to collect warnings, but threading a similar mechanism through the exporter would be a bit of a chore, so I didn't do that yet.