-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve error handling #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j33ty
approved these changes
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Left some minor comments.
Let's merge this one and then I can rebase it on top of my changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fun story; I was not aware that you were working on this, @j33ty - just as I was opening this PR I noticed #3
Feel free to either ignore this PR, or pick parts of it - up to you.
I started out wanting to fix an issue where certain errors seem to silently be swallowed. I believe some of those stem from the fact that any errors thrown in the promise constructor body is lost. The relevant fix for that is in e981a92. The change might look big, but it's really just about using a deferred promise (eg what is today
Promise.withResolvers()
) and lifting the logic up one scope, thus the large diff.While doing this change and adding tests, I realized that there were other problems, so I attempted to fix those as well:
500: Internal Server Error
it would print something likeExport: HTTP 500: Internal Server Error: Some descriptive message from the backend
Failed to parse error response from asset stream
, even when that wasn't the case