Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter out deleted jobs #24

Merged

Conversation

arthur-pinner
Copy link
Contributor

@arthur-pinner arthur-pinner commented Sep 12, 2023

Filter out deleted jobs while searching for them

While searching for existing jobs, if a previous job has been cancelled, the plugin does still display the View Job button.
When you click on the VIew Job butotn the image below is displayed in Smartling

Screenshot 2023-09-12 at 10 19 44

Steps to reproduce:

  1. Create a new content
  2. Go to Translations Tab , select one or more locales and click on Create Job
  3. After the job has been created, click on View Job to be redirect to Smartling job's page.
  4. Click on Cancel button on the left (first widget) and provide a reason why you are canceling it
  5. Go back to Translations Tab in Sanity Studio and refresh the page.
  6. The View Job button is displayed (it should be displayed)

@cngonzalez cngonzalez merged commit 6a3608a into sanity-io:main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants