Skip to content

Commit

Permalink
fix: submit requestedRole as name not title
Browse files Browse the repository at this point in the history
  • Loading branch information
drewlyton committed Sep 30, 2024
1 parent d43421c commit 2524e47
Showing 1 changed file with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,13 @@ export function RequestPermissionDialog({
const [hasTooManyRequests, setHasTooManyRequests] = useState<boolean>(false)
const [hasBeenDenied, setHasBeenDenied] = useState<boolean>(false)

const requestedRole$: Observable<'Administrator' | 'Editor'> = useMemo(() => {
const adminRole = 'Administrator' as const
const requestedRole$: Observable<'administrator' | 'editor'> = useMemo(() => {
const adminRole = 'administrator' as const
if (!projectId || !client) return of(adminRole)
return client.observable.request<Role[]>({url: `/projects/${projectId}/roles`}).pipe(
map((roles) => {
const hasEditor = roles.find((role) => role.name === 'editor')
return hasEditor ? 'Editor' : adminRole
return hasEditor ? 'editor' : adminRole
}),
startWith(adminRole),
catchError(() => of(adminRole)),
Expand All @@ -73,7 +73,7 @@ export function RequestPermissionDialog({

const requestedRole = useObservable(requestedRole$)

const onConfirm = () => {
const onSubmit = () => {
setIsSubmitting(true)
client
.request<AccessRequest | null>({
Expand Down Expand Up @@ -128,7 +128,7 @@ export function RequestPermissionDialog({
disabled: hasTooManyRequests || hasBeenDenied,
text: t('request-permission-dialog.confirm-button.text'),
tone: 'primary',
onClick: onConfirm,
type: 'submit',
},
}}
onClose={onClose}
Expand All @@ -154,7 +154,7 @@ export function RequestPermissionDialog({
placeholder={t('request-permission-dialog.note-input.placeholder.text')}
disabled={isSubmitting}
onKeyDown={(e) => {
if (e.key === 'Enter') onConfirm()
if (e.key === 'Enter') onSubmit()
}}
maxLength={MAX_NOTE_LENGTH}
value={note}
Expand Down

0 comments on commit 2524e47

Please sign in to comment.