fix: return undefined as machine id if it can't be determined

sanity-io · Sep 24, 2024 · 3da8a9a · 3da8a9a
1 parent 51c5e70
commit 3da8a9a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/packages/@sanity/cli/src/cli.ts b/packages/@sanity/cli/src/cli.ts
@@ -44,9 +44,8 @@ function installProcessExitHack(finalTask: () => Promise<unknown>) {
 async function getDeviceId() {
   try {
     return await machineId()
-  } catch(error) {
-    console.error('Failed to get device ID:', error)
-    return 'unknown device id'
+  } catch (error) {
+    return undefined
   }
 }
 

diff --git a/packages/@sanity/cli/src/types.ts b/packages/@sanity/cli/src/types.ts
@@ -94,7 +94,7 @@ export interface CliBaseCommandContext {
 }
 
 export interface TelemetryUserProperties {
-  deviceId: string
+  deviceId: string | undefined
   runtime: string
   runtimeVersion: string
   cliVersion: string