Skip to content

Commit

Permalink
chore: hide publish date (#7162)
Browse files Browse the repository at this point in the history
  • Loading branch information
RitaDias authored and bjoerge committed Aug 20, 2024
1 parent 60006d4 commit 746e5be
Show file tree
Hide file tree
Showing 8 changed files with 33 additions and 41 deletions.
6 changes: 2 additions & 4 deletions packages/sanity/src/core/bundles/components/BundleMenu.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import {CheckmarkIcon} from '@sanity/icons'
import {Box, Flex, Menu, MenuButton, MenuDivider, MenuItem, Spinner, Text} from '@sanity/ui'
import {type ReactElement, useCallback} from 'react'
import {RelativeTime} from 'sanity'
import {styled} from 'styled-components'

import {type BundleDocument} from '../../store/bundles/types'
Expand Down Expand Up @@ -91,16 +90,15 @@ export function BundleMenu(props: BundleListProps): JSX.Element {
</Text>
</Box>

<Box padding={2}>
{/*<Box padding={2}>
<Text muted size={1}>
{b.publishAt ? (
<RelativeTime time={b.publishAt as Date} useTemporalPhrase />
) : (
/* localize text */
'No target date'
)}
</Text>
</Box>
</Box>*/}

<Box padding={2}>
<Text size={1}>
Expand Down
36 changes: 15 additions & 21 deletions packages/sanity/src/core/bundles/components/dialog/BundleForm.tsx
Original file line number Diff line number Diff line change
@@ -1,19 +1,18 @@
/* eslint-disable i18next/no-literal-string */
import {CalendarIcon} from '@sanity/icons'
import {Box, Button, Flex, Popover, Stack, Text, TextArea, TextInput} from '@sanity/ui'
//import {CalendarIcon} from '@sanity/icons'
import {Flex, Stack, Text, TextArea, TextInput} from '@sanity/ui'
import {useCallback, useMemo, useState} from 'react'
import {
FormFieldHeaderText,
type FormNodeValidation,
useBundles,
useDateTimeFormat,
useTranslation,
//useDateTimeFormat,
//useTranslation,
} from 'sanity'
import speakingurl from 'speakingurl'

import {type CalendarLabels} from '../../../form/inputs/DateInputs/base/calendar/types'
import {DatePicker} from '../../../form/inputs/DateInputs/base/DatePicker'
import {getCalendarLabels} from '../../../form/inputs/DateInputs/utils'
//import {type CalendarLabels} from '../../../form/inputs/DateInputs/base/calendar/types'
//import {getCalendarLabels} from '../../../form/inputs/DateInputs/utils'
import {type BundleDocument} from '../../../store/bundles/types'
import {isDraftOrPublished} from '../../util/dummyGetters'
import {BundleIconEditorPicker, type BundleIconEditorPickerValue} from './BundleIconEditorPicker'
Expand All @@ -24,29 +23,26 @@ export function BundleForm(props: {
value: Partial<BundleDocument>
}): JSX.Element {
const {onChange, onError, value} = props
const {title, description, icon, hue, publishAt} = value
const {title, description, icon, hue /*, publishAt*/} = value

const dateFormatter = useDateTimeFormat()
//const dateFormatter = useDateTimeFormat()

const [showDateValidation, setShowDateValidation] = useState(false)
const [showDatePicker, setShowDatePicker] = useState(false)
const [showBundleExists, setShowBundleExists] = useState(false)
const [showIsDraftPublishError, setShowIsDraftPublishError] = useState(false)

const [isInitialRender, setIsInitialRender] = useState(true)
const {data} = useBundles()

const [titleErrors, setTitleErrors] = useState<FormNodeValidation[]>([])
const [dateErrors, setDateErrors] = useState<FormNodeValidation[]>([])
/*const [dateErrors, setDateErrors] = useState<FormNodeValidation[]>([])
const publishAtDisplayValue = useMemo(() => {
/*const publishAtDisplayValue = useMemo(() => {
if (!publishAt) return ''
return dateFormatter.format(new Date(publishAt as Date))
}, [dateFormatter, publishAt])
const [displayDate, setDisplayDate] = useState(publishAtDisplayValue)
const {t: coreT} = useTranslation()
const calendarLabels: CalendarLabels = useMemo(() => getCalendarLabels(coreT), [coreT])
const calendarLabels: CalendarLabels = useMemo(() => getCalendarLabels(coreT), [coreT])*/

const iconValue: BundleIconEditorPickerValue = useMemo(
() => ({
Expand Down Expand Up @@ -112,7 +108,7 @@ export function BundleForm(props: {
setShowDatePicker(!showDatePicker)
}, [showDatePicker])

const handleBundlePublishAtChange = useCallback(
/*const handleBundlePublishAtChange = useCallback(
(nextDate: Date | undefined) => {
onChange({...value, publishAt: nextDate})
setDisplayDate(dateFormatter.format(new Date(nextDate as Date)))
Expand All @@ -131,7 +127,6 @@ export function BundleForm(props: {
// in which case it can update the input value but not the actual bundle value
if (new Date(event.target.value).toString() === 'Invalid Date' && dateValue !== '') {
// if the date is invalid, show an error
// TODO localize text
setDateErrors([
{
level: 'error',
Expand All @@ -149,7 +144,7 @@ export function BundleForm(props: {
}
},
[onChange, value, onError],
)
)*/

const handleIconValueChange = useCallback(
(pickedIcon: BundleIconEditorPickerValue) => {
Expand Down Expand Up @@ -186,8 +181,7 @@ export function BundleForm(props: {
/>
</Stack>

<Stack space={3}>
{/* localize text */}
{/*<Stack space={3}>
<FormFieldHeaderText title="Schedule for publishing at" validation={dateErrors} />
<TextInput
Expand Down Expand Up @@ -223,7 +217,7 @@ export function BundleForm(props: {
data-testid="bundle-form-publish-at"
customValidity={dateErrors.length > 0 ? 'error' : undefined}
/>
</Stack>
</Stack>*/}
</Stack>
)
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export function CreateBundleDialog(props: CreateBundleDialogProps): JSX.Element
title: '',
hue: 'gray',
icon: 'cube',
publishAt: undefined,
//publishAt: undefined,
})
const [isCreating, setIsCreating] = useState(false)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ describe('BundleForm', () => {
description: '',
icon: 'cube',
hue: 'gray',
publishAt: undefined,
//publishAt: undefined,
}

beforeEach(async () => {
Expand Down Expand Up @@ -62,7 +62,7 @@ describe('BundleForm', () => {
it('should render the form fields', () => {
expect(screen.getByTestId('bundle-form-title')).toBeInTheDocument()
expect(screen.getByTestId('bundle-form-description')).toBeInTheDocument()
expect(screen.getByTestId('bundle-form-publish-at')).toBeInTheDocument()
//expect(screen.getByTestId('bundle-form-publish-at')).toBeInTheDocument()
})

it('should call onChange when title input value changes', () => {
Expand All @@ -79,7 +79,7 @@ describe('BundleForm', () => {
expect(onChangeMock).toHaveBeenCalledWith({...valueMock, description: 'New Description'})
})

it('should call onChange when publishAt input value changes', () => {
/*it('should call onChange when publishAt input value changes', () => {
const publishAtInput = screen.getByTestId('bundle-form-publish-at')
fireEvent.change(publishAtInput, {target: {value: '2022-01-01'}})
Expand All @@ -91,7 +91,7 @@ describe('BundleForm', () => {
fireEvent.change(publishAtInput, {target: {value: ' '}})
expect(onChangeMock).toHaveBeenCalledWith({...valueMock, publishAt: ''})
})
})*/

it('should show an error when the title is "drafts"', () => {
const titleInput = screen.getByTestId('bundle-form-title')
Expand Down Expand Up @@ -123,10 +123,10 @@ describe('BundleForm', () => {
expect(screen.getByTestId('input-validation-icon-error')).toBeInTheDocument()
})

it('should show an error when the publishAt input value is invalid', () => {
/*it('should show an error when the publishAt input value is invalid', () => {
const publishAtInput = screen.getByTestId('bundle-form-publish-at')
fireEvent.change(publishAtInput, {target: {value: 'invalid-date'}})
expect(screen.getByTestId('input-validation-icon-error')).toBeInTheDocument()
})
})*/
})
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import {beforeEach, describe, expect, it, jest} from '@jest/globals'
import {fireEvent, render, screen} from '@testing-library/react'
import {type BundleDocument, useBundles, useDateTimeFormat} from 'sanity'
import {type BundleDocument, useBundles} from 'sanity'

import {useBundleOperations} from '../../../../store/bundles/useBundleOperations'
import {usePerspective} from '../../../hooks/usePerspective'
import {createWrapper} from '../../../util/tests/createWrapper'
import {CreateBundleDialog} from '../CreateBundleDialog'

jest.mock('../../../../../core/hooks/useDateTimeFormat', () => ({
/*jest.mock('../../../../../core/hooks/useDateTimeFormat', () => ({
useDateTimeFormat: jest.fn(),
}))
}))*/

jest.mock('../../../../store/bundles', () => ({
useBundles: jest.fn(),
Expand All @@ -28,7 +28,7 @@ jest.mock('../../../hooks/usePerspective', () => ({
}))

const mockUseBundleStore = useBundles as jest.Mock<typeof useBundles>
const mockUseDateTimeFormat = useDateTimeFormat as jest.Mock
//const mockUseDateTimeFormat = useDateTimeFormat as jest.Mock

describe('CreateBundleDialog', () => {
const onCancelMock = jest.fn()
Expand All @@ -44,7 +44,7 @@ describe('CreateBundleDialog', () => {
dispatch: jest.fn(),
})

mockUseDateTimeFormat.mockReturnValue({format: jest.fn().mockReturnValue('Mocked date')})
//mockUseDateTimeFormat.mockReturnValue({format: jest.fn().mockReturnValue('Mocked date')})

const wrapper = await createWrapper()
render(<CreateBundleDialog onCancel={onCancelMock} onCreate={onCreateMock} />, {wrapper})
Expand All @@ -66,7 +66,7 @@ describe('CreateBundleDialog', () => {
title: 'Bundle 1',
hue: 'gray',
icon: 'cube',
publishAt: undefined,
//publishAt: undefined,
}

const titleInput = screen.getByTestId('bundle-form-title')
Expand Down
2 changes: 1 addition & 1 deletion packages/sanity/src/core/bundles/util/const.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ export const LATEST: Partial<BundleDocument> = {
title: 'Latest',
icon: undefined,
tone: 'gray',
publishAt: '',
//publishAt: '',
}
2 changes: 1 addition & 1 deletion packages/sanity/src/core/bundles/util/dummyGetters.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export async function getAllVersionsOfDocument(
title: bundle?.title || sluggedName,
hue: bundle?.hue || 'gray',
icon: bundle?.icon || 'cube',
publishAt: bundle?.publishAt,
//publishAt: bundle?.publishAt,
}
})
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const WithAddonDatasetProvider = <P extends object>(Component: ComponentType<P>)
return WrappedComponent
}

const initialValue = {name: '', title: '', tone: undefined, publishAt: undefined}
const initialValue = {name: '', title: '', tone: undefined /*, publishAt: undefined*/}

const BundlesStoreStory = () => {
const {data, loading} = useBundles()
Expand Down

0 comments on commit 746e5be

Please sign in to comment.