fix(core): don't iterate on target schemaType if sourceValue is empty

sanity-io · Jun 17, 2024 · a6c6202 · a6c6202
1 parent 0e2ae36
commit a6c6202
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/packages/sanity/src/core/studio/copyPaste/__test__/schema.tsx b/packages/sanity/src/core/studio/copyPaste/__test__/schema.tsx
@@ -34,6 +34,16 @@ const nestedObjectType = defineType({
       name: 'objectList',
       of: [{type: 'nestedObject'}],
     },
+    {
+      type: 'object',
+      name: 'recursiveTest',
+      fields: [
+        {
+          name: 'recursive',
+          type: 'nestedObject',
+        },
+      ],
+    },
   ],
 })
 

diff --git a/packages/sanity/src/core/studio/copyPaste/valueTransfer.ts b/packages/sanity/src/core/studio/copyPaste/valueTransfer.ts
@@ -160,6 +160,12 @@ function collateObjectValue({
   errors: TransferValueError[]
   keyGenerator: () => string
 }) {
+  if (isEmptyValue(sourceValue)) {
+    return {
+      targetValue: undefined,
+      errors,
+    }
+  }
   if (targetSchemaType.readOnly) {
     return {
       targetValue: undefined,