chore(docs): fix dataset delete script #4906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add more logging in delete script - use PR numbers as dataset names instead of github ref
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Component Testing Report Updated Sep 8, 2023 1:13 PM (UTC)
|
|
No changes to documentation |
bjoerge
reviewed
Sep 7, 2023
.github/workflows/docReport.yml
Outdated
| @@ -51,14 +51,14 @@ jobs: | |||
| if: ${{ github.event_name == 'pull_request' }} | |||
| env: | |||
| DOCS_REPORT_TOKEN: ${{ secrets.DOCS_REPORT_DATASET_TOKEN }} | |||
| DOCS_REPORT_DATASET: ${{ github.ref_name }} | |||
| DOCS_REPORT_DATASET: ${{ github.event.number }} | |||
There was a problem hiding this comment.
should we prefx it so it's easy to identify as a temporary dataset?
There was a problem hiding this comment.
sure I can take a look at how to do that
bjoerge
approved these changes
Sep 11, 2023
rexxars
pushed a commit
that referenced
this pull request
Sep 12, 2023
* chore(docs): fix dataset delete script - add more logging in delete script - use PR numbers as dataset names instead of github ref * chore(docs): prefix dataset name with pr * chore(docs): fix turbo token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What to review
Seems like when the PR is closed the ref actually points to the next branch so it ends up deleting the next dataset. It seems like the
github.event.numbershould be more consistent. ReferenceNotes for release
N/A