Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fixes issue with restoring document in nested panes #4915

Merged
merged 2 commits into from
Sep 13, 2023
Merged

fix(core): fixes issue with restoring document in nested panes #4915

merged 2 commits into from
Sep 13, 2023

Conversation

binoy14
Copy link
Contributor

@binoy14 binoy14 commented Sep 11, 2023

Description

This PR fixes the hacky workaround in #4668 in a more predictable way where it only navigates to the intent when the operation is successfully completed.

What to review

The solution makes sense and there would be no side effects of this change.

Notes for release

  • Fixes issue with restoring document history in nested panes

@vercel
Copy link

vercel bot commented Sep 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Sep 13, 2023 3:07pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 3:07pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2023 3:07pm

@binoy14 binoy14 requested a review from a team September 11, 2023 18:11
@github-actions
Copy link
Contributor

No changes to documentation

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023 •
edited
Loading

Component Testing Report Updated Sep 13, 2023 3:10 PM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 10s 6 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 14s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 52s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 6s 3 0 0

@bjoerge bjoerge changed the title fix(core): fixes issue with resotring document in nested panes fix(core): fixes issue with restoring document in nested panes Sep 12, 2023
bjoerge
bjoerge approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, @binoy14!

@binoy14 binoy14 added this pull request to the merge queue Sep 13, 2023
Merged via the queue into next with commit 47f3be9 Sep 13, 2023
14 checks passed
@binoy14 binoy14 deleted the feature/sdx-728 branch September 13, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricokahler ricokahler ricokahler approved these changes

@bjoerge bjoerge bjoerge approved these changes

@rexxars rexxars Awaiting requested review from rexxars

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binoy14 @bjoerge @ricokahler