Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fixes issue with overlapping text in error message #4970

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix(core): fixes issue with overlapping text in error message #4970

merged 1 commit into from
Oct 12, 2023

Conversation

binoy14
Copy link
Contributor

@binoy14 binoy14 commented Oct 3, 2023

Description

Before

Screenshot 2023-09-27 at 10 44 46

After

Screenshot 2023-10-03 at 12 25 08 PM

What to review

Adds a text overflow with title to the breadcrumbs so it still provides the user with the full name on hover

Notes for release

  • Fixes an issue with text overlapping in error message

@vercel
Copy link

vercel bot commented Oct 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Oct 3, 2023 4:30pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 4:30pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Oct 3, 2023 4:30pm

@binoy14 binoy14 requested a review from a team October 3, 2023 16:29
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

No changes to documentation

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Component Testing Report Updated Oct 3, 2023 4:36 PM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 15s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 52s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 7s 3 0 0

@bjoerge bjoerge force-pushed the next branch 2 times, most recently from e7bf4c3 to 4151f2e Compare October 9, 2023 11:02
@binoy14 binoy14 added this pull request to the merge queue Oct 12, 2023
Merged via the queue into next with commit 2001ced Oct 12, 2023
14 checks passed
@binoy14 binoy14 deleted the sdx-738 branch October 12, 2023 18:54
rexxars pushed a commit that referenced this pull request Oct 20, 2023
@binoy14 @rexxars
fix(core): fixes issue with overlapping text in error message (#4970)
b6a268a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoerge bjoerge bjoerge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@binoy14 @bjoerge