Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): set fallback placement for type-select popover in array input #4979

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Oct 6, 2023

Description

Follow-up from #4963, which missed a fix for the popover that appears when adding an item to an array input that can hold several diferent types.

Before:
image
After:
image

What to review

  • Make sure long lists of possible types are placed either above or below the "Add item…" button in array inputs

Notes for release

  • Fixed placement of "Add item…" popover in array inputs

@bjoerge bjoerge requested a review from ninaandal October 6, 2023 10:48
@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Oct 6, 2023 10:49am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 10:49am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Oct 6, 2023 10:49am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

No changes to documentation

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Component Testing Report Updated Oct 6, 2023 10:53 AM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 5s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 9s 6 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 12s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 44s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 10s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 5s 3 0 0

@bjoerge bjoerge added this pull request to the merge queue Oct 9, 2023
Merged via the queue into next with commit 0068787 Oct 9, 2023
14 checks passed
@bjoerge bjoerge deleted the sdx-730 branch October 9, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants