Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): convert review changes button to use i18n primitives #4993

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

jtpetty
Copy link
Contributor

@jtpetty jtpetty commented Oct 13, 2023

Description

This PR adds i18n support for the ReviewChangesButton

@vercel
Copy link

vercel bot commented Oct 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Oct 16, 2023 7:26pm
studio-workshop 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 7:26pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 7:26pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

Package Documentation Change
sanity +7%
sanity/desk +2%
@sanity/types -11%
Full Report
sanity
This branch Next branch
127 documented 119 documented
847 not documented 825 not documented
sanity/desk
This branch Next branch
84 documented 83 documented
56 not documented 55 not documented
@sanity/diff
This branch Next branch
13 documented 13 documented
16 not documented 16 not documented
@sanity/block-tools
This branch Next branch
4 documented 4 documented
9 not documented 9 not documented
@sanity/portable-text-editor
This branch Next branch
21 documented 21 documented
44 not documented 44 not documented
@sanity/mutator
This branch Next branch
7 documented 7 documented
4 not documented 4 not documented
@sanity/cli
This branch Next branch
1 documented 1 documented
30 not documented 30 not documented
@sanity/schema/_internal
This branch Next branch
0 documented 0 documented
9 not documented 9 not documented
@sanity/util/paths
This branch Next branch
1 documented 1 documented
15 not documented 15 not documented
sanity/router
This branch Next branch
15 documented 15 documented
21 not documented 21 not documented
@sanity/util/legacyDateFormat
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
@sanity/schema
This branch Next branch
0 documented 0 documented
2 not documented 2 not documented
sanity/cli
This branch Next branch
2 documented 2 documented
0 not documented 0 not documented
@sanity/vision
This branch Next branch
0 documented 0 documented
2 not documented 2 not documented
@sanity/util/fs
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
sanity/_internal
This branch Next branch
0 documented 0 documented
1 not documented 1 not documented
@sanity/util/content
This branch Next branch
1 documented 1 documented
5 not documented 5 not documented
@sanity/types
This branch Next branch
47 documented 53 documented
240 not documented 233 not documented

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

Component Testing Report Updated Oct 16, 2023 7:31 PM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 16s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 54s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 7s 3 0 0

Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we talked about over PM, maybe the .tooltip should be at the end? No strong preferences, but should be consistent at least.

Comment on lines +128 to +131
'status-bar.review-changes-button.tooltip.text': 'Review changes',

/** Text for the secondary text for tooltip for the button */
'status-bar.review-changes-button.tooltip.changes-saved': 'Changes saved',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency I guess the .tooltip should be at the end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe? it's the same tool tip, but this tool tip has a primary and secondary text.

@rexxars rexxars changed the title feat(i18n): Review Changes Button feat(i18n): convert review changes button to use i18n primitives Oct 13, 2023
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtpetty jtpetty force-pushed the feat/i18n-review-changes-button branch from ce4744b to a9ce2d4 Compare October 16, 2023 19:26
@jtpetty jtpetty merged commit 49cbdc6 into feat/i18n Oct 16, 2023
17 checks passed
@jtpetty jtpetty deleted the feat/i18n-review-changes-button branch October 16, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants