-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): convert review changes button to use i18n primitives #4993
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Full Reportsanity
sanity/desk
@sanity/diff
@sanity/block-tools
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/util/legacyDateFormat
@sanity/schema
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/content
@sanity/types
|
Component Testing Report Updated Oct 16, 2023 7:31 PM (UTC)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we talked about over PM, maybe the .tooltip
should be at the end? No strong preferences, but should be consistent at least.
'status-bar.review-changes-button.tooltip.text': 'Review changes', | ||
|
||
/** Text for the secondary text for tooltip for the button */ | ||
'status-bar.review-changes-button.tooltip.changes-saved': 'Changes saved', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency I guess the .tooltip
should be at the end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe? it's the same tool tip, but this tool tip has a primary and secondary text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ce4744b
to
a9ce2d4
Compare
Description
This PR adds i18n support for the ReviewChangesButton