chore(i18n): add the i18next/no-literal-string eslint rule #4998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We generally prefer interfaces, but this in particular allows us to extend the type from the `sanity` module using declaration merging. While not the optimal choice (the whole type should really just be in the `sanity` module), it is at least addressing the problem until we can do a breaking change in the types module.
Because there can be several validation errors/warnings/info messages for a single field, simply using the field path as key is not enough, since React only renders a single element per parent with a given key.
This is required because non-React codepaths will simply fail/throw when attempting to use a namespace that is not defined. An example is the upcoming validation system, where the validation system is decoupled from the React lifecycle, and so cannot rely on Suspense in order to load missing namespaces.
…rimitivesFunctions
Makes it easier to see which areas are not yet localized
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Component Testing Report Updated Oct 16, 2023 8:18 PM (UTC)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an eslint rule that will fail if the javascript file contains literal English strings.