Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(login): fix issue where logo is not shown on custom auth providers #5002

Merged
merged 2 commits into from
Oct 20, 2023
Merged

fix(login): fix issue where logo is not shown on custom auth providers #5002

merged 2 commits into from
Oct 20, 2023

Conversation

binoy14
Copy link
Contributor

@binoy14 binoy14 commented Oct 17, 2023

Description

Fixes an issue where custom logo would not show up on custom auth providers unless the name of the provider was custom and even in that case it would throw an error since the provider prop was not passed to the component.

Screenshot 2023-10-17 at 11 35 56 AM

What to review

Change makes sense

Notes for release

  • Fixes an issue where logo is not shown on custom auth providers

@binoy14 binoy14 requested a review from a team October 17, 2023 15:40
@vercel
Copy link

vercel bot commented Oct 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Oct 18, 2023 2:51pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 2:51pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2023 2:51pm

@github-actions
Copy link
Contributor

No changes to documentation

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023 •
edited
Loading

Component Testing Report Updated Oct 18, 2023 2:50 PM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 10s 6 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 15s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 49s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 6s 3 0 0

@skogsmaskin @binoy14
doc(sanity): add TS-doc for block content related types (#4674)
3e33c26 
* chore(core/form/inputs): remove outdated workshop case

Remove this non-working workshop left over from v2

* refactor(core/form/inputs): deprecate block marker callbacks and support

* doc(types): add ts doc comments to block schema types

* doc(sanity): add TS-doc for block content related types
bjoerge
bjoerge approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

skogsmaskin
skogsmaskin approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@skogsmaskin skogsmaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@binoy14 binoy14 added this pull request to the merge queue Oct 20, 2023
Merged via the queue into next with commit 744bfdf Oct 20, 2023
17 checks passed
@binoy14 binoy14 deleted the sdx-793 branch October 20, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoerge bjoerge bjoerge approved these changes

@skogsmaskin skogsmaskin skogsmaskin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binoy14 @skogsmaskin @bjoerge