Feat/comments mvi 1 testing #5007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Full Reportsanity
@sanity/diff
@sanity/block-tools
@sanity/types
sanity/desk
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/util/legacyDateFormat
@sanity/schema
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/content
|
|
Component Testing Report Updated Oct 20, 2023 11:50 AM (UTC)
|
skogsmaskin
force-pushed
the
feat/comments-mvi-1-testing
branch
from
1e87659
to
66ba56c
Compare
skogsmaskin
force-pushed
the
feat/comments-mvi-1-testing
branch
from
66ba56c
to
ea3bb0d
Compare
skogsmaskin
force-pushed
the
feat/comments-mvi-1-testing
branch
from
ea3bb0d
to
9e42f83
Compare
skogsmaskin
force-pushed
the
feat/comments-mvi-1-testing
branch
from
9e42f83
to
64c7b3c
Compare
hermanwikner
force-pushed
the
feat/comments-mvi-1
branch
from
6ecf925
to
ee8546f
Compare
skogsmaskin
force-pushed
the
feat/comments-mvi-1-testing
branch
from
64c7b3c
to
12486b1
Compare
…st condition * Track editor focus for a focusPath that points to a span's text property. * Harden test for span text by testing that the _type property is actually a 'span' too. I found and issue where inline blocks having a .text property also triggered editor focus here, which they shouldn't.
Set the initial editor selection based on the focusPath at mount time. This case needs to be handled explicitly through a inititalSelection prop on the Edtiable component of the PTE.
Allow tests to specify their own document and focusPath
Seems like WebKit behaves a bit differently than the other browsers in regard to the initial focusPath, add method to ensure that the focusPath is propagated before we start to test against it.
'hasFocus' here really means: does it has focus inside the editor itself? As opposed focus on some object inside the editor content (object blocks etc).
Use children here instead, so tests not testing forms can use it too. The TestForm will be passed by the different stories instead.
Retry setting focus until the editor has applied all of it's operations. This will ensure that we don't call focus until the editor has applied the final selection. There is currently a bug in slate-react Editable that will cause errors if we are trying to call ReactEditor.focus in the midst of a transform.
…ting This will make sure that the produced Range actually is pointing to content. Error if the Range is invalid.
There was a bug in the delete function that could leave the editor in a broken state if the last block is removed from the content.
This will fix a issue with the wrong path being sent to the delete function and focus can now be called without a setTimeout because of a bugfix in the PortableTextEditor.
Add a couple of test-ids we will need when writing tests.
This will fix some bugs we have been seeing related to setting focus in the comment input. Use the PTE Editable selection prop to control selecting end of the content. Call focus on the editor without side-effects.
There is no longer a need to re-focus the editor when toggling fullscreen, so this code can be removed. Also use a state inside PortableTextEditor to control hasFocusWithin where the editable itself will control the focus directly.
Add some basic tests for the comment input. More to come.
The toolbar popover should not show when the annotation object is open. Also make sure it is displayed again when closing the editing popover.
skogsmaskin
force-pushed
the
feat/comments-mvi-1-testing
branch
from
933daca
to
5195533
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What to review
Notes for release