Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(facelift): create StudioUI tooltip with delay and replace #5016

Merged
merged 12 commits into from
Oct 30, 2023

Conversation

ninaandal
Copy link
Contributor

@ninaandal ninaandal commented Oct 19, 2023

Description

Starting the work of Studio UI - this PR adds the StudioUI tooltip with an globally added delay, but passes on the other props.
Since the StudioUI tooltuip now have a default padding, this PR also removes the paddings added to the tooltips for consistency.

What to review

Since this PR changes all tooltips in the studio, all of them should be properly tested to make sure they are looking as they should

Adding some videos to show where many of the tooltips can be found:

Screen.Recording.2023-10-24.at.20.45.40.mov
Screen.Recording.2023-10-24.at.20.45.10.mov
Screen.Recording.2023-10-24.at.20.47.49.mov
Screenshot 2023-10-24 at 20 52 57
Screen.Recording.2023-10-24.at.20.53.46.mov
Screenshot 2023-10-24 at 21 40 03

Notes for release

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Oct 26, 2023 1:30pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 1:30pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 1:30pm

@github-actions
Copy link
Contributor

Package Documentation Change
sanity -7%
@sanity/types -13%
Full Report
@sanity/diff
This branch Next branch
13 documented 13 documented
16 not documented 16 not documented
@sanity/block-tools
This branch Next branch
4 documented 4 documented
9 not documented 9 not documented
sanity/desk
This branch Next branch
83 documented 83 documented
55 not documented 55 not documented
@sanity/portable-text-editor
This branch Next branch
21 documented 21 documented
44 not documented 44 not documented
@sanity/mutator
This branch Next branch
7 documented 7 documented
4 not documented 4 not documented
@sanity/cli
This branch Next branch
1 documented 1 documented
30 not documented 30 not documented
@sanity/schema/_internal
This branch Next branch
0 documented 0 documented
9 not documented 9 not documented
@sanity/util/paths
This branch Next branch
1 documented 1 documented
15 not documented 15 not documented
sanity/router
This branch Next branch
15 documented 15 documented
21 not documented 21 not documented
@sanity/util/legacyDateFormat
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
@sanity/schema
This branch Next branch
0 documented 0 documented
2 not documented 2 not documented
sanity/cli
This branch Next branch
2 documented 2 documented
0 not documented 0 not documented
@sanity/vision
This branch Next branch
0 documented 0 documented
2 not documented 2 not documented
@sanity/util/fs
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
sanity/_internal
This branch Next branch
0 documented 0 documented
1 not documented 1 not documented
@sanity/util/content
This branch Next branch
1 documented 1 documented
5 not documented 5 not documented
sanity
This branch Next branch
110 documented 119 documented
834 not documented 825 not documented
@sanity/types
This branch Next branch
46 documented 53 documented
240 not documented 233 not documented

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

Component Testing Report Updated Oct 26, 2023 1:32 PM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 10s 6 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 14s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 51s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 7s 3 0 0

@ninaandal ninaandal marked this pull request as ready for review October 24, 2023 11:51
Copy link
Contributor

@robinpyon robinpyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ninaandal – interesting to see exactly how many instances there are (and how much variance there is layout wise).

Upon using it, maybe we'll want to tweak that delay slightly (but this change makes it much easier to do so globally)

Left a minor comment on tooltip styling but otherwise LGTM!

packages/sanity/src/ui/tooltip/Tooltip.tsx Outdated Show resolved Hide resolved
@ninaandal ninaandal merged commit 13d0c3e into feat/facelift-mvi-2 Oct 30, 2023
17 checks passed
@ninaandal ninaandal deleted the edx-472-revised branch October 30, 2023 11:43
robinpyon added a commit that referenced this pull request Nov 2, 2023
* feat(facelift): create StudioUI tooltip with delay and replace

* fix(core/desk): use StudioUi Tooltip

* fix(core/desk): use Studio UI tooltip

* fix(core/desk): use StudioUI tooltip and remove paddings

* fix(core): use StudioUI tooltip for TooltipOfDisabled - ref prop error

* fix(src): fix studioUI tooltip to take strings and replace current tooltips with this logic

* fix(vision): change tooltip import path

* fix(src): fix up content in StudioUI tooltips, remove comment

* fix(core): add two arguments to forwardRef render function

* fix(test-studio): add custom badge to author schema type

* Update packages/sanity/src/ui/tooltip/Tooltip.tsx

Co-authored-by: Robin Pyon <[email protected]>

* refactor: slightly DRY tooltip component

---------

Co-authored-by: Robin Pyon <[email protected]>
Co-authored-by: Robin Pyon <[email protected]>
robinpyon added a commit that referenced this pull request Nov 3, 2023
* feat(facelift): create StudioUI tooltip with delay and replace

* fix(core/desk): use StudioUi Tooltip

* fix(core/desk): use Studio UI tooltip

* fix(core/desk): use StudioUI tooltip and remove paddings

* fix(core): use StudioUI tooltip for TooltipOfDisabled - ref prop error

* fix(src): fix studioUI tooltip to take strings and replace current tooltips with this logic

* fix(vision): change tooltip import path

* fix(src): fix up content in StudioUI tooltips, remove comment

* fix(core): add two arguments to forwardRef render function

* fix(test-studio): add custom badge to author schema type

* Update packages/sanity/src/ui/tooltip/Tooltip.tsx

Co-authored-by: Robin Pyon <[email protected]>

* refactor: slightly DRY tooltip component

---------

Co-authored-by: Robin Pyon <[email protected]>
Co-authored-by: Robin Pyon <[email protected]>
robinpyon added a commit that referenced this pull request Nov 8, 2023
* feat(facelift): create StudioUI tooltip with delay and replace

* fix(core/desk): use StudioUi Tooltip

* fix(core/desk): use Studio UI tooltip

* fix(core/desk): use StudioUI tooltip and remove paddings

* fix(core): use StudioUI tooltip for TooltipOfDisabled - ref prop error

* fix(src): fix studioUI tooltip to take strings and replace current tooltips with this logic

* fix(vision): change tooltip import path

* fix(src): fix up content in StudioUI tooltips, remove comment

* fix(core): add two arguments to forwardRef render function

* fix(test-studio): add custom badge to author schema type

* Update packages/sanity/src/ui/tooltip/Tooltip.tsx

Co-authored-by: Robin Pyon <[email protected]>

* refactor: slightly DRY tooltip component

---------

Co-authored-by: Robin Pyon <[email protected]>
Co-authored-by: Robin Pyon <[email protected]>
robinpyon added a commit that referenced this pull request Nov 18, 2023
* feat(facelift): create StudioUI tooltip with delay and replace

* fix(core/desk): use StudioUi Tooltip

* fix(core/desk): use Studio UI tooltip

* fix(core/desk): use StudioUI tooltip and remove paddings

* fix(core): use StudioUI tooltip for TooltipOfDisabled - ref prop error

* fix(src): fix studioUI tooltip to take strings and replace current tooltips with this logic

* fix(vision): change tooltip import path

* fix(src): fix up content in StudioUI tooltips, remove comment

* fix(core): add two arguments to forwardRef render function

* fix(test-studio): add custom badge to author schema type

* Update packages/sanity/src/ui/tooltip/Tooltip.tsx

Co-authored-by: Robin Pyon <[email protected]>

* refactor: slightly DRY tooltip component

---------

Co-authored-by: Robin Pyon <[email protected]>
Co-authored-by: Robin Pyon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants