refactor(i18n): pass locale to help/versions check #5022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Full Reportsanity
sanity/desk
@sanity/diff
@sanity/block-tools
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/util/legacyDateFormat
@sanity/schema
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/content
@sanity/types
|
|
Component Testing Report Updated Oct 20, 2023 7:43 PM (UTC)
|
bjoerge
approved these changes
Oct 20, 2023
| @@ -19,7 +19,7 @@ export function getHelpResources( | |||
| Builds to: `{m: ['[email protected]']}' and serializes to: `[email protected]`. | |||
| Final format will be e.g. https://api.sanity.io/v1/help?tag=sanity.studio.module.version-check&m=sanity%403.0.2 | |||
| */ | |||
| query: {m: [`sanity@${SANITY_VERSION}`]}, | |||
| query: {m: [`sanity@${SANITY_VERSION}`], locale}, | |||
There was a problem hiding this comment.
can the above todo comment now be removed?
There was a problem hiding this comment.
Oh, thanks - yes! - missed it 😅
|
lgtm - just a comment/question |
rexxars
force-pushed
the
refactor/pass-locale-param
branch
from
fc43e5a
to
9fdcbcb
Compare
bjoerge
pushed a commit
that referenced
this pull request
Oct 23, 2023
bjoerge
pushed a commit
that referenced
this pull request
Nov 6, 2023
bjoerge
pushed a commit
that referenced
this pull request
Nov 6, 2023
bjoerge
pushed a commit
that referenced
this pull request
Nov 6, 2023
rexxars
added a commit
that referenced
this pull request
Nov 17, 2023
rexxars
added a commit
that referenced
this pull request
Nov 20, 2023
rexxars
added a commit
that referenced
this pull request
Nov 22, 2023
bjoerge
pushed a commit
that referenced
this pull request
Nov 27, 2023
bjoerge
pushed a commit
that referenced
this pull request
Nov 28, 2023
rexxars
added a commit
that referenced
this pull request
Nov 28, 2023
rexxars
added a commit
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes the
localeparameter to the/helpendpoint, in order to (at some point) be able to localize the responses.