Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(form): add doc and example for components extention of block type #5059

Merged
merged 1 commit into from
Oct 24, 2023
Merged

doc(form): add doc and example for components extention of block type #5059

merged 1 commit into from
Oct 24, 2023

Conversation

skogsmaskin
Copy link
Member

Description

This will add some TS-doc with examples to the block component extension.

What to review

That it's correctly written and makes sense.

Notes for release

N/A

@vercel
Copy link

vercel bot commented Oct 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Oct 24, 2023 0:20am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 0:20am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Oct 24, 2023 0:20am

@skogsmaskin skogsmaskin marked this pull request as ready for review October 24, 2023 12:18
@github-actions
Copy link
Contributor

No changes to documentation

@github-actions
Copy link
Contributor

Component Testing Report Updated Oct 24, 2023 12:26 PM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 15s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 49s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 6s 3 0 0

bjoerge
bjoerge approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@skogsmaskin skogsmaskin added this pull request to the merge queue Oct 24, 2023
Merged via the queue into next with commit 5233f35 Oct 24, 2023
21 checks passed
@skogsmaskin skogsmaskin deleted the doc/block-extension branch October 24, 2023 14:21
skogsmaskin added a commit that referenced this pull request Nov 2, 2023
@skogsmaskin
doc(form): add doc and example for components extention of block type (…
10d1b59 
…#5059)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoerge bjoerge bjoerge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skogsmaskin @bjoerge