-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(i18n): add no-literal-string lint exceptions for __workshop__ dirs #5064
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Full Reportsanity
@sanity/types
sanity/desk
@sanity/diff
@sanity/block-tools
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/util/legacyDateFormat
@sanity/schema
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/content
|
Component Testing Report Updated Oct 24, 2023 5:54 PM (UTC)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocking comment but there is an overrides
configuration setting for eslint that we could use to ignore that rule for certain files when ran at a top-level. Would that be better?
I went back and forth on that. I ultimately decided rather than a global rule, doing each directory separately would allow us to choose to make these workshop directories accessible in the future independently if we wanted to. |
…irs (#5064) * chore(i18n): add no-literal-string lint exceptions for __workshop__ directories * chore(i18n): add lint exceptions for __tests__
…irs (#5064) * chore(i18n): add no-literal-string lint exceptions for __workshop__ directories * chore(i18n): add lint exceptions for __tests__
…irs (#5064) * chore(i18n): add no-literal-string lint exceptions for __workshop__ directories * chore(i18n): add lint exceptions for __tests__
…irs (#5064) * chore(i18n): add no-literal-string lint exceptions for __workshop__ directories * chore(i18n): add lint exceptions for __tests__
…irs (#5064) * chore(i18n): add no-literal-string lint exceptions for __workshop__ directories * chore(i18n): add lint exceptions for __tests__
…irs (#5064) * chore(i18n): add no-literal-string lint exceptions for __workshop__ directories * chore(i18n): add lint exceptions for __tests__
…irs (#5064) * chore(i18n): add no-literal-string lint exceptions for __workshop__ directories * chore(i18n): add lint exceptions for __tests__
…irs (#5064) * chore(i18n): add no-literal-string lint exceptions for __workshop__ directories * chore(i18n): add lint exceptions for __tests__
…irs (#5064) * chore(i18n): add no-literal-string lint exceptions for __workshop__ directories * chore(i18n): add lint exceptions for __tests__
…irs (#5064) * chore(i18n): add no-literal-string lint exceptions for __workshop__ directories * chore(i18n): add lint exceptions for __tests__
Description
Since we are not translating files in
__workshop__
directories, this PR disables theno-literal-string
rule for these directories.