Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(i18n): add no-literal-string lint exceptions for __workshop__ dirs #5064

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

jtpetty
Copy link
Contributor

@jtpetty jtpetty commented Oct 24, 2023

Description

Since we are not translating files in __workshop__ directories, this PR disables the no-literal-string rule for these directories.

@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Oct 24, 2023 6:03pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 6:03pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2023 6:03pm

@github-actions
Copy link
Contributor

Package Documentation Change
sanity +19%
@sanity/types +2%
sanity/desk +2%
Full Report
sanity
This branch Next branch
141 documented 119 documented
839 not documented 825 not documented
@sanity/types
This branch Next branch
54 documented 53 documented
233 not documented 233 not documented
sanity/desk
This branch Next branch
84 documented 83 documented
56 not documented 55 not documented
@sanity/diff
This branch Next branch
13 documented 13 documented
16 not documented 16 not documented
@sanity/block-tools
This branch Next branch
4 documented 4 documented
9 not documented 9 not documented
@sanity/portable-text-editor
This branch Next branch
21 documented 21 documented
44 not documented 44 not documented
@sanity/mutator
This branch Next branch
7 documented 7 documented
4 not documented 4 not documented
@sanity/cli
This branch Next branch
1 documented 1 documented
30 not documented 30 not documented
@sanity/schema/_internal
This branch Next branch
0 documented 0 documented
9 not documented 9 not documented
@sanity/util/paths
This branch Next branch
1 documented 1 documented
15 not documented 15 not documented
sanity/router
This branch Next branch
15 documented 15 documented
21 not documented 21 not documented
@sanity/util/legacyDateFormat
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
@sanity/schema
This branch Next branch
0 documented 0 documented
2 not documented 2 not documented
sanity/cli
This branch Next branch
2 documented 2 documented
0 not documented 0 not documented
@sanity/vision
This branch Next branch
0 documented 0 documented
2 not documented 2 not documented
@sanity/util/fs
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
sanity/_internal
This branch Next branch
0 documented 0 documented
1 not documented 1 not documented
@sanity/util/content
This branch Next branch
1 documented 1 documented
5 not documented 5 not documented

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

Component Testing Report Updated Oct 24, 2023 5:54 PM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 7s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 10s 6 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 14s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 48s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 7s 3 0 0

Copy link
Contributor

@ricokahler ricokahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocking comment but there is an overrides configuration setting for eslint that we could use to ignore that rule for certain files when ran at a top-level. Would that be better?

@jtpetty
Copy link
Contributor Author

jtpetty commented Oct 25, 2023

Not a blocking comment but there is an overrides configuration setting for eslint that we could use to ignore that rule for certain files when ran at a top-level. Would that be better?

I went back and forth on that. I ultimately decided rather than a global rule, doing each directory separately would allow us to choose to make these workshop directories accessible in the future independently if we wanted to.

@jtpetty jtpetty merged commit e09c796 into feat/i18n Oct 25, 2023
21 checks passed
@jtpetty jtpetty deleted the feat/i18n-eslint-rule-exceptions branch October 25, 2023 15:59
bjoerge pushed a commit that referenced this pull request Nov 6, 2023
…irs (#5064)

* chore(i18n): add no-literal-string lint exceptions for __workshop__ directories

* chore(i18n): add lint exceptions for __tests__
bjoerge pushed a commit that referenced this pull request Nov 6, 2023
…irs (#5064)

* chore(i18n): add no-literal-string lint exceptions for __workshop__ directories

* chore(i18n): add lint exceptions for __tests__
bjoerge pushed a commit that referenced this pull request Nov 6, 2023
…irs (#5064)

* chore(i18n): add no-literal-string lint exceptions for __workshop__ directories

* chore(i18n): add lint exceptions for __tests__
rexxars pushed a commit that referenced this pull request Nov 17, 2023
…irs (#5064)

* chore(i18n): add no-literal-string lint exceptions for __workshop__ directories

* chore(i18n): add lint exceptions for __tests__
rexxars pushed a commit that referenced this pull request Nov 20, 2023
…irs (#5064)

* chore(i18n): add no-literal-string lint exceptions for __workshop__ directories

* chore(i18n): add lint exceptions for __tests__
rexxars pushed a commit that referenced this pull request Nov 22, 2023
…irs (#5064)

* chore(i18n): add no-literal-string lint exceptions for __workshop__ directories

* chore(i18n): add lint exceptions for __tests__
bjoerge pushed a commit that referenced this pull request Nov 27, 2023
…irs (#5064)

* chore(i18n): add no-literal-string lint exceptions for __workshop__ directories

* chore(i18n): add lint exceptions for __tests__
bjoerge pushed a commit that referenced this pull request Nov 28, 2023
…irs (#5064)

* chore(i18n): add no-literal-string lint exceptions for __workshop__ directories

* chore(i18n): add lint exceptions for __tests__
rexxars pushed a commit that referenced this pull request Nov 28, 2023
…irs (#5064)

* chore(i18n): add no-literal-string lint exceptions for __workshop__ directories

* chore(i18n): add lint exceptions for __tests__
rexxars pushed a commit that referenced this pull request Nov 28, 2023
…irs (#5064)

* chore(i18n): add no-literal-string lint exceptions for __workshop__ directories

* chore(i18n): add lint exceptions for __tests__
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants