feat(i18n): updates translation for form/inputs/files #5127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Full Reportsanity
@sanity/types
sanity/desk
@sanity/diff
@sanity/block-tools
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/util/legacyDateFormat
@sanity/schema
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/content
|
|
Component Testing Report Updated Nov 6, 2023 5:29 PM (UTC)
|
rexxars
requested changes
Nov 3, 2023
| @@ -126,7 +129,7 @@ export function FileActionsMenu(props: Props) { | |||
| constrainSize | |||
| > | |||
| <Button | |||
| aria-label="Open file options menu" | |||
| aria-label={t('inputs.files.image.actions-menu.files.aria-label')} | |||
There was a problem hiding this comment.
This key doesn't make sense to me...
Multiple file and also an image?
There was a problem hiding this comment.
Yeah, I was going by what was already in the resource file. I think @bjoerge was following the directory path, which makes some sense.
There was a problem hiding this comment.
yeah, I was mirroring the way the files are organized, but agree it reads weird. inputs.image.actions-menu… should suffice.
There was a problem hiding this comment.
I see what I did and what made it extra confusing was this key having 'image' in it at all. 😬 . I fixed this one and the others ones to remove 'files'
There was a problem hiding this comment.
Ah! It was in the File component, didn't catch that.
packages/sanity/src/core/form/inputs/files/FileInput/FileActionsMenu.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/core/form/inputs/files/FileInput/FileInput.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/core/form/inputs/files/FileInput/FileInput.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/core/form/inputs/files/FileInput/InvalidFileWarning.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/core/form/inputs/files/ImageInput/InvalidImageWarning.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/core/form/inputs/files/ImageToolInput/ImageToolInput.tsx
Outdated
Show resolved
Hide resolved
bjoerge
approved these changes
Nov 6, 2023
bjoerge
force-pushed
the
feat/i18n
branch
2 times, most recently
from
a6d47ad
to
deff5ab
Compare
bjoerge
force-pushed
the
feat/i18n-inputs-files
branch
from
785533b
to
96d5f0e
Compare
|
This PR is superseded by #5134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates translation for files in
packages/sanity/src/core/form/inputs/files