Facelift/cherrypick title #5151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(facelift): create StudioUI tooltip with delay and replace * fix(core/desk): use StudioUi Tooltip * fix(core/desk): use Studio UI tooltip * fix(core/desk): use StudioUI tooltip and remove paddings * fix(core): use StudioUI tooltip for TooltipOfDisabled - ref prop error * fix(src): fix studioUI tooltip to take strings and replace current tooltips with this logic * fix(vision): change tooltip import path * fix(src): fix up content in StudioUI tooltips, remove comment * fix(core): add two arguments to forwardRef render function * fix(test-studio): add custom badge to author schema type * Update packages/sanity/src/ui/tooltip/Tooltip.tsx Co-authored-by: Robin Pyon <[email protected]> * refactor: slightly DRY tooltip component --------- Co-authored-by: Robin Pyon <[email protected]> Co-authored-by: Robin Pyon <[email protected]>
* feat(facelift): create menu item StudioUI * fix(facelift): refactor workspace preview to use large menu item * fix(facelift): support icon right in large menu item * feat(facelift): update StudioUI Menu item props, remove size * feat(facelift): add Studio UI menu item stories * fix(tests): update snapshot
* fix(alpha-ui): support for breaking changes inside studio with new sanity/ui (#5015) * feat(facelift): implement Dialog into studio UI * feat(facelift): update dialog designs, configIssues, cors and inspect * fix(dialogs): update import paths * fix(dialogs): update available props in StudioUI Dialog * chore(deps): update @sanity/ui * fix: standardize dialog padding, add support for padding + custom contentHeight, tweak type sizes * fix: re-add missing document reference count card * chore: update snapshots * refactor: remove hardcoded px values, tweak reference styles --------- Co-authored-by: Robin Pyon <[email protected]>
* feat(facelift): add StudioUI <Button /> * feat(facelift): update imports after branch rebase * feat(facelift): transform lint rule to error, update document publish button. Pass on pr review * fix: revert studio ui changes in non package dirs * refactor: remove unused imports, minor changes --------- Co-authored-by: Robin Pyon <[email protected]>
…ooltips, remove extraneous padding from reference preview + presence tooltips
…draft status components
…nt rule to only check against packages/sanity
* feat(navbar): started studio ui navbar work * fix(core): studio navbar work * feat: first pass of updated navbar search, deprecate components.logo, remove previous placeholder search components * fix: revert CollapseMenuButton changes * fix: remove duplicate studio navbar border * fix: re-add user avatar color --------- Co-authored-by: Robin Pyon <[email protected]>
…arning heading styles
… preview skeletons
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Nov 8, 2023 6:10 PM (UTC)
|
robinpyon
force-pushed
the
feat/facelift-mvi-2
branch
from
28ca2d5
to
64f6d3e
Compare
robinpyon
requested review from
hermanwikner,
skogsmaskin,
bjoerge and
RitaDias
as code owners
ninaandal
force-pushed
the
facelift/cherrypick-title
branch
from
8fd9bff
to
cfa5160
Compare
* feat(core): avoid layout shift when editing title Fixes SDX-672 * refactor(core): use line clamp for the title truncating
ninaandal
force-pushed
the
facelift/cherrypick-title
branch
from
cfa5160
to
9cc70c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherrypicked from Binoy's great work on the document title 🏅
Have only added a maximum of 4 lines to the title height.
What to review
The new title headers in the documents
Notes for release