-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): upgrade vite
to v5
#5285
base: next
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
Component Testing Report Updated Oct 1, 2024 8:37 PM (UTC) ✅ All Tests Passed -- expand for details
|
c11e97b
to
3b108dc
Compare
7d88873
to
0a1c062
Compare
0a1c062
to
c968882
Compare
c968882
to
2cde9ef
Compare
Getting errors of I think ideally we'd move towards an ESM-first CLI that does not bundle build the CLI to a single file (previously this was done because npm2 used an absurd amount of time installing dependencies - that story is now better, and we have less dependencies than back then too). |
Having said that, if we can make it still make it work with today's solution, I'd be more than happy to look at the altered approach. |
2835d1a
to
3c0029f
Compare
3c0029f
to
fb10cbe
Compare
Description
Vite v5 is full of goodies, perf and fixes.
And v5.1
What to review
sanity dev
should hot reload faster,sanity build
should be significantly faster. The existing public API shouldn't break and v3 plugins should continue to bundle.It can be tested using
pnpm i [email protected]
Notes for release
fix(deps): upgrade to
vite
v5 for speediersanity dev
andsanity build
DX ✨