Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): upgrade vite to v5 #5285

Open
wants to merge 9 commits into
base: next
Choose a base branch
from
Open

fix(deps): upgrade vite to v5 #5285

wants to merge 9 commits into from

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Nov 28, 2023

Description

Vite v5 is full of goodies, perf and fixes.

And v5.1

What to review

sanity dev should hot reload faster, sanity build should be significantly faster. The existing public API shouldn't break and v3 plugins should continue to bundle.
It can be tested using pnpm i [email protected]

Notes for release

fix(deps): upgrade to vite v5 for speedier sanity dev and sanity build DX ✨

Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 8:32pm
performance-studio ✅ Ready (Inspect) Visit Preview Oct 1, 2024 8:32pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 8:32pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 8:32pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 8:32pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 8:32pm

Copy link
Contributor

github-actions bot commented Nov 28, 2023

No changes to documentation

Copy link
Contributor

github-actions bot commented Nov 28, 2023

Component Testing Report Updated Oct 1, 2024 8:37 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 32s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 38s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 46s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 41s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 19s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 27s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 19s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 36s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@stipsan stipsan force-pushed the update-bundling branch 2 times, most recently from c11e97b to 3b108dc Compare November 29, 2023 23:32
Base automatically changed from update-bundling to next November 30, 2023 10:31
@stipsan stipsan marked this pull request as ready for review November 30, 2023 10:32
@stipsan stipsan requested a review from a team November 30, 2023 10:32
@bjoerge bjoerge requested review from bjoerge and removed request for a team December 12, 2023 12:54
@stipsan stipsan requested a review from a team December 13, 2023 02:43
@stipsan stipsan requested a review from a team as a code owner December 13, 2023 02:43
@rexxars
Copy link
Member

rexxars commented Dec 13, 2023

Getting errors of The CJS build of Vite's Node API is deprecated. Not sure quite how to resolve this - esbuild-register kind of messes up the stack trace, and the way we bundle everything into a single file kind of makes things even more complicated.

I think ideally we'd move towards an ESM-first CLI that does not bundle build the CLI to a single file (previously this was done because npm2 used an absurd amount of time installing dependencies - that story is now better, and we have less dependencies than back then too).

@rexxars
Copy link
Member

rexxars commented Dec 13, 2023

Having said that, if we can make it still make it work with today's solution, I'd be more than happy to look at the altered approach.

@bjoerge bjoerge requested review from rexxars and removed request for bjoerge and a team January 2, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants