-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): restore platform-aware keyboard shortcuts #6819
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
Component Testing Report Updated Jul 11, 2024 6:11 PM (UTC)
|
85536c5
to
f4184c8
Compare
juice49
previously approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
sjelfull
previously approved these changes
Jun 21, 2024
f4184c8
to
ec99e03
Compare
ec99e03
to
3a10939
Compare
ricokahler
approved these changes
Jul 11, 2024
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seems the facelift PR caused a regression that basically reverted this PR in terms of end result.
This PR reverts to using the
<Hotkeys>
component from the sanity core, which is platform aware.What to review
Ctrl + Option + P
on publish and similar, when on MacCtrl + Alt + P
on publish and similar, when not on Mac(This should be uncovered by the test suite, fwiw)
Testing
I added one test for this in the publish action. Ideally I would test all the different locations that use any kind of hotkeys that may involve the
Alt
key, but that would be a lot of tests in a lot of different places. I may introduce an ESLint rule to disallow the use of<Hotkeys>
from@sanity/ui
later.Notes for release